Skip to content

Conversation

@Timeless0911
Copy link
Contributor

Summary

Enable pnpm's new no-downgrade trustPolicy. This helps prevent installing potentially compromised versions of a package.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 13, 2025 06:29
@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit be4c19b
🔍 Latest deploy log https://app.netlify.com/projects/rslib/deploys/69157adf48c9b00008a8e596
😎 Deploy Preview https://deploy-preview-1333--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot finished reviewing on behalf of Timeless0911 November 13, 2025 06:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances security by enabling pnpm's no-downgrade trustPolicy, which prevents installing potentially compromised downgraded versions of packages. The pnpm package manager is upgraded from version 10.21.0 to 10.22.0 to support this feature.

  • Added trustPolicy: no-downgrade setting to pnpm workspace configuration
  • Updated pnpm version requirement from 10.21.0 to 10.22.0

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pnpm-workspace.yaml Adds trustPolicy: no-downgrade configuration to enable security protection against package downgrades
package.json Updates pnpm version from 10.21.0 to 10.22.0 in both packageManager field and engines requirement to support the new trustPolicy feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenjiahan
Copy link
Member

@Timeless0911
Copy link
Contributor Author

Timeless0911 commented Nov 13, 2025

We can exclude chokidar: web-infra-dev/rslib/actions/runs/19322701784/job/55267109693?pr=1333#step:8:7

There are many packages similar to chokidar, it might result in a very long list to config. The problem here is why running pnpm dedupe results in an error while pnpm install does not. pnpm/pnpm#8889 (comment)

@chenjiahan
Copy link
Member

Get, we can wait for pnpm to fix the pnpm dedupe issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants