Skip to content

Commit 8ac49f3

Browse files
chore(contributing): update threshold for PR approvals and fast-tracking (nodejs#2908)
* chore(contributing): update threshold for PR approvals and fast-tracking Signed-off-by: Claudio Wunder <[email protected]> * Update CONTRIBUTING.md Signed-off-by: Claudio Wunder <[email protected]> Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]>
1 parent f1b9d7e commit 8ac49f3

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,10 @@ Basic rules:
9898

9999
### Before merging
100100

101-
* Pull Requests must be open for at least 48 hours unless changes include errata fixes, infrastructure maintenance, or tests.
102-
* There must be no objections after 48 hours.
101+
* Pull Requests must be open for at least 48 hours.
102+
* Pull reuqests might be immediately merged if they contain critical bug fixes, short erratas (e.g. typos from previous PRs) or any critical change that is considered a "showstopper" for the operation of the website.
103+
* These kind of PRs should only be done by existing collaborators that have write-access and/or signed-off by administrators/maintainers.
104+
* There must be no objections after a 48 hour period
103105
* Tests must be included in Pull Requests for new features or bug fixes. If any test(s) are failing, you are responsible for fixing them.
104106

105107
Each contribution is accepted only if there is no objection to it by a collaborator. During the review, collaborators may request that a specific contributor who is an expert in a particular area give an "LGTM" before the PR can be merged.

0 commit comments

Comments
 (0)