Bug: Sidebar collapse preference does not persist after reload

[cleanjunc]

Collapsing the left or right sidebar works visually, but the state is lost after a page reload. The sidebar always reopens.

The app-layout Stimulus controller reads this.userIdValue when saving the preference, but the controller never declares a static values block. Because userId is not registered, Stimulus does not bind the data-app-layout-user-id-value attribute set in the layout, and this.userIdValue is undefined.

As a result every toggle sends a request to /users/undefined, which cannot update show_sidebar or show_ai_sidebar. The preference is never stored, so the layout resets on the next load.

Steps to reproduce

1. Collapse the left or right sidebar.
2. Reload the page.
3. The sidebar is expanded again.

Expected

The collapsed or expanded state is remembered across reloads.

Notes

UsersController#update already permits show_sidebar and show_ai_sidebar, and the layout already renders data-app-layout-user-id-value. The only missing piece is the value declaration on the controller.

[dosubot]

Good catch. I can confirm the bug — the controller at app/javascript/controllers/app_layout_controller.js declares static targets and static classes but is missing a static values declaration [1]. Because of this, Stimulus never binds this.userIdValue, and the fetch on line 49 interpolates undefined into the URL [2].

The fix is to add the values declaration to the controller:

static values = { userId: Number };

This should go after the existing static classes block (around line 11). Once declared, Stimulus will read the data-app-layout-user-id-value attribute already rendered in the layout [3] and this.userIdValue will resolve to the current user's ID, allowing the PATCH to /users/:id to succeed.

To reply, just mention @dosu.

---

Share context across your team and agents. Try Dosu.