Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The unattended uses a non-existent source_branch #2674

Closed
juliamagan opened this issue Dec 11, 2023 · 0 comments
Closed

The unattended uses a non-existent source_branch #2674

juliamagan opened this issue Dec 11, 2023 · 0 comments
Assignees
Labels
level/task Subtask issue type/bug Bug issue

Comments

@juliamagan
Copy link
Member

Wazuh version Install type Action performed
4.7.1-rc2 Unattended Install

Description

During the creation of packages for 4.7.1 RC2, in https://github.com/wazuh/wazuh-jenkins/issues/6056, it was found that we could not generate the unattended because it could not download dist-detect.sh:

09:50:51  + /home/ec2-user/workspace/publish_unattended/unattended_installer/builder.sh -i -c -p -d
09:50:51  Error: Could not get the dist-detect file.

Reviewing the code, we have seen that source_branch is hardcoded to 4.7.0, a branch that does not exist since 4.7.0 was released:

readonly source_branch="4.7.0"

This variable should be taken from some parameter and not be hardcoded, to avoid errors in the future and not having to be updating it every time there is a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Subtask issue type/bug Bug issue
Projects
No open projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants