Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve filesystem implementation #638

Open
aritosteles opened this issue Feb 27, 2025 · 1 comment · May be fixed by #661
Open

Improve filesystem implementation #638

aritosteles opened this issue Feb 27, 2025 · 1 comment · May be fixed by #661
Assignees
@aritosteles
Labels
level/subtask Subtask issue module/agent type/enhancement Enhancement issue

Comments

@aritosteles
Copy link
Contributor

Improve implementation by separating the functions that are purely wrappers from those that add logic.

../common/file_helper/
├── CMakeLists.txt
└── filesystem
    ├── include
    │   ├── filesystem_utils.hpp
    │   ├── filesystem_wrapper.hpp
    │   ├── ifilesystem_utils.hpp
    │   └── ifilesystem_wrapper.hpp
    ├── src
    │   ├── filesystem_utils.cpp
    │   └── filesystem_wrapper.cpp
    └── tests
        ├── CMakeLists.txt
		├── filesystem_utils_test.cpp
        ├── filesystem_wrapper_test.cpp
        └── mocks
            ├── mock_filesystem_utils.hpp
        	└── mock_filesystem_wrapper.hpp
@aritosteles aritosteles added the level/subtask Subtask issue label Feb 27, 2025
@aritosteles aritosteles self-assigned this Feb 27, 2025
@wazuhci wazuhci moved this to Backlog in XDR+SIEM/Release 5.0.0 Feb 27, 2025
@wazuhci wazuhci moved this from Backlog to In progress in XDR+SIEM/Release 5.0.0 Mar 7, 2025
@aritosteles
Copy link
Contributor Author

aritosteles commented Mar 10, 2025 •
edited
Loading

Update

  • 10/03/2025:
    Added fixture to file_io_utils_test.cpp which was pending from previous issue.
    Started looking into FileSystemWrapper::expand_absolute_path() which is the one function that contains any logic and needs work. Needs to be implemented non recursively and needs to leverage modern c++ features.
  • 12/03/2025:
    Fixed existing bugs in FileSystemWrapper::expand_absolute_path() and utils::patternMatch() functions. Reimplemented utils::patternMatch() function using a Dynamic Programming algorithm.

@aritosteles aritosteles linked a pull request Mar 13, 2025 that will close this issue
Improve filesystem implementation #661
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aritosteles aritosteles

Labels
level/subtask Subtask issue module/agent type/enhancement Enhancement issue
Projects
XDR+SIEM/Release 5.0.0
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve filesystem implementation wazuh/wazuh-agent
2 participants
@TomasTurina @aritosteles