Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add zh-cn, zh-tw support #69

Merged
merged 1 commit into from
Jan 22, 2024
Merged

feat: add zh-cn, zh-tw support #69

merged 1 commit into from
Jan 22, 2024

Conversation

tsinggggg
Copy link
Contributor

@tsinggggg tsinggggg commented Jan 19, 2024 •
edited
Loading

  • adding zh-cn and zh-tw support
  • tested locally with workspaces from internal issue 62213
  • default chinese tokenizer in spacy v2 doesn't seem to perform well, using jieba which is not available until spacy v3

@tsinggggg tsinggggg requested a review from haodeqi January 22, 2024 13:32
@tsinggggg
Copy link
Contributor Author

tsinggggg commented Jan 22, 2024 •
edited
Loading

Hi @haodeqi , would you please review this PR when you have some time? Thank you!

Build finishes now, previous failure was due to some issue in dev.

haodeqi
haodeqi approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@haodeqi haodeqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you Cheng.

@haodeqi haodeqi merged commit 3172999 into master Jan 22, 2024
5 of 7 checks passed
@haodeqi haodeqi deleted the chinese branch January 22, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haodeqi haodeqi haodeqi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsinggggg @haodeqi