Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra validation rules for deps in package.json #2317

Open
infomiho opened this issue Oct 3, 2024 · 0 comments
Open

Add extra validation rules for deps in package.json #2317

infomiho opened this issue Oct 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@infomiho
Copy link
Contributor

infomiho commented Oct 3, 2024

In #2297 we added validation for userland config files e.g. package.json and tsconfig.json. We validated only package versions that were seen causing issues i.e. Prisma and React Router.

There is no reason not to validate all the required packages:

  • react
  • @types/react
  • vite
    etc.

Basically, add some extra rules that would prevent users from installing e.g. React 19 when it comes out before Wasp migrates to the new version fully.

@infomiho infomiho added the enhancement New feature or request label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant