-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASM validator module #18
Comments
This task has three parts:
|
@Steampunkery and I implemented verification for a subset of numeric instructions in our fork. parity-wasm checks types for const operators but not for binary as specified in the spec. We simulated the stack to check for types and hence we added a new validator interface that takes in a mutable self reference. We also use a self defined enum instead of String for error handling and propagation as advised by the documentation. We will be happy to submit a PR if it will be helpful to wasm-chisel. |
Can you please open a PR? We can review it that way. |
There is no validation in parity-wasm left and everything migrated to wasmi (see this). Moreover, when we started compiling wasm into internal wasmi IR validation became mixed with compilation concerns. There was some interest in creating a separate reusable crate from third-parties. I think parity will need this as well at some point. |
@pepyakin thanks for the heads up! |
This should do semantic validation of the module according to the Wasm specification.
Must also first check how much of that is done by pwasm.
The text was updated successfully, but these errors were encountered: