Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore files with alternate renderers #247

Open
ggiesen opened this issue Mar 8, 2021 · 3 comments
Open

Ignore files with alternate renderers #247

ggiesen opened this issue Mar 8, 2021 · 3 comments
Labels

Comments

@ggiesen
Copy link

ggiesen commented Mar 8, 2021

Is your feature request related to a problem? Please describe.
salt-lint currently attempts to lint all files passed to it, even if they have a header for an alternate renderer (ie. #!py)

Describe the solution you'd like
Have salt-lint ignore files using alternate renderers.

Alternatively, provide an option to call another linting tool (configurable per renderer)

Describe alternatives you've considered
I tried using some combination of find and awk to exclude those files, but the syntax is a mess and escaping it sufficiently to work with tox is a nightmare.

@ggiesen ggiesen added the Type: Enhancement New feature or request label Mar 8, 2021
@roaldnefs
Copy link
Member

Thanks @ggiesen for your feature request! Using an alternate renderer may indeed cause false positive results. The simplest solution would indeed be to ignore files with alternate renderer.

@auphofBSF
Copy link

"provide an option to call another linting tool (configurable per renderer)" would be my request (pretty pleases) 🙏🙏🙏🙏🙏

I am doing some work with the py renderer and constantly having to change file name from py to sls and back. Would be really cool for the sls to just use the python linting in vscode to just work for sls files with shebangs like #!py or #!pyobjects or #!pydsl

@roaldnefs
Copy link
Member

I am doing some work with the py renderer and constantly having to change file name from py to sls and back. Would be really cool for the sls to just use the python linting in vscode to just work for sls files with shebangs like #!py or #!pyobjects or #!pydsl

Thanks @auphofBSF for your feature request! As this depends on the language detecting in VSCode, would you be willing to create a feature request in warpnet/vscode-salt-lint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants