feat: use lease instead of image metadata for reference count #152
Conversation
|
will reopen as soon as I have a fixed version |
| @@ -47,6 +47,7 @@ func NewNodeServer(driver *csicommon.CSIDriver, mounter backend.Mounter, imageSv | |||
| SecretStore: secretStore, | |||
| Mounter: mounter, | |||
| }), | |||
| k8smounter: k8smount.New(""), | |||
There was a problem hiding this comment.
FYI. this is needed, so that the "unsafe mount" detection happens only once. It clutters the logs quite a bit
There was a problem hiding this comment.
This is based on the "general" mounter, but was needed because for leases some different behaviour is required. If you are fine with this PR in general, I would refactor that so that there are two distinct mounters, which suites it purpose best.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. |
|
Closing this PR after a prolonged period of inactivity. Please create a new PR if the changes of the PR are still relevant. |
This PR is aiming to fix #151
It changes the implementation to use leases in containerd instead of labels to keep references to the snapshots.
This also has the benefit that the metadata does not need to be updated all the time. Which looks like to lead to timeouts on high churn clusters.
This adds a
USE_LEASE_ONLYenv flag for the testing phase which does not delete snapshots explictily, etc. This should be removed in the final version, including most of the sourcecode around that.I opened the PR to get some feedback from you. Thanks!