Twitter Redux Project Feedback!

[codepathreview]

👍 Nice work! We added this homework so that you'll have the experience building an app that's more similar in complexity to a production app. The optional account switching feature is interesting because you have to think about how TwitterClient is caching the access token to make sure it works correctly for multiple accounts.

• In general, good work cleaning up and organizing the code, most of the classes look pretty good.
• Nice job utilizing enums and structs for your Twitter client and models.
• I wouldn't expect more refactoring in the current sprint timeframe. If we had more time, we might look at the following items:
• TimelineViewController is probably the most complex class in the project at the moment, and is a good target for more simplification. For instance, infinite reloading is a fairly common task, how you could make it more re-usable.
• In TweetViewController, you can move the date formatter code to the model.
• In ComposeViewController, you can refactor to a reusable UITextView w/ placeholder class.
• In TweetCell, move the Date extension into its own file.
• When you have Auto Layout, you shouldn't need to call sizeToFit any more.

We have a detailed Project 4 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. You should consider going back and implementing these improvements as well.

If you have any particular questions about the assignment or the feedback, email us at [email protected].

Congratulations on finishing the final assignment! It's impressive to realize that in just four weeks, you've gone from building a simple tip calculator app to a polished MVC client.