Ensure showHiddenFiles works with directory dialog

[leaanthony]

Description

Allows "showHiddenFiles" to work with directory dialogs.

Fixes #2454

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of hidden files in both Open and Save file dialogs for a clearer user experience.

• Refactor

  • Streamlined code for setting properties in file dialogs to enhance clarity and maintainability.

[coderabbitai]

Walkthrough

The changes made in the pull request involve modifications to the OpenFileDialog and SaveFileDialog methods within the WailsContext class. The adjustments focus on the handling of the showsHiddenFiles property to ensure it is set correctly, thereby refining the visibility of hidden files in file dialogs. The overall functionality remains unchanged, with improvements aimed at code clarity and consistency.

Changes

File	Change Summary
v2/internal/frontend/desktop/darwin/WailsContext.m	Updated OpenFileDialog and SaveFileDialog methods to clarify handling of showsHiddenFiles.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure hidden files and folders are visible in dialogs (#2454)	❓	It's unclear if the change fully addresses visibility for hidden folders.

Poem

In the land of code where rabbits play,
Hidden files now come out to say,
"We're here, we're clear, no need to hide,
With dialogs open, come take a ride!" 🐇✨
WailsContext shines, a clearer view,
For every rabbit, and coder too!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 63e1f3c and 483ca9e.

📒 Files selected for processing (1)

• v2/internal/frontend/desktop/darwin/WailsContext.m (1 hunks)

🔇 Additional comments (1)

v2/internal/frontend/desktop/darwin/WailsContext.m (1)

598-598: LGTM! This change correctly implements hidden files visibility.

The implementation properly uses the native macOS API to control hidden file visibility in both file and directory dialogs, which directly addresses issue #2454.

Let's verify that this behavior is consistently handled across the codebase:

✅ Verification successful

Hidden files visibility is consistently implemented across platforms

The verification confirms that the showHiddenFiles feature is properly integrated across the codebase:

• The option is defined in the common OpenDialogOptions and SaveDialogOptions structs in frontend.go
• Linux implementation correctly handles it in window.go and dialog.go
• macOS (Darwin) implementation properly passes it to both open and save dialogs
• The feature is consistently used in both file and directory selection dialogs

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for other dialog implementations that might need similar hidden files handling
# Look for other implementations of file/directory dialogs
rg -l "ShowHiddenFiles|showHiddenFiles" --type go

# Look for related test files
fd -e test.go

Length of output: 236

---

Script:

#!/bin/bash
# Check the implementation of showHiddenFiles in other platforms
rg -A 5 -B 5 "ShowHiddenFiles|showHiddenFiles" --type go

Length of output: 6988

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cloudflare-workers-and-pages]

Deploying wails with    Cloudflare Pages

Latest commit:	483ca9e
Status:	✅  Deploy successful!
Preview URL:	https://30b1f7d7.wails.pages.dev
Branch Preview URL:	https://v2-bugfix-show-hidden-files.wails.pages.dev

View logs