Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wails doctor reports Windows 11 as "Windows 10" #3890

Closed
ronen25 opened this issue Nov 17, 2024 · 1 comment · May be fixed by #3891
Closed

wails doctor reports Windows 11 as "Windows 10" #3890

ronen25 opened this issue Nov 17, 2024 · 1 comment · May be fixed by #3891
Labels
Bug Something isn't working

Comments

@ronen25
Copy link

ronen25 commented Nov 17, 2024 •
edited
Loading

Description

Small issue with wails doctor: running on a Windows 11 system, under "System", the OS is reported as "Windows 10 Home" although it is in fact Windows 11 Home on the tested device.

The rest of the information is reported correctly.

It's not really a big deal though because, well, the reporting is correct to an extent; both major versions of 10 and 11 are indeed 10:

PS C:\Users\Ronen\Developer\wails> cmd /c ver

Microsoft Windows [Version 10.0.22631.4317]

But I think a correct identification will be nicer :-)

To Reproduce

  1. Use a machine running any edition of Windows 11
  2. Install the wails CLI
  3. Run wails doctor
  4. Under "System", OS is reported as "Windows 10 [EDITION]" instead of "Windows 11 [EDITION]"

Expected behaviour

Tested on a Surface Pro 9 with Windows 11, I expect a "Windows 11 Home" string to appear under OS.

Screenshots

No response

Attempted Fixes

No response

System Details

# Wails
Version | v2.9.2

# System
┌─────────────────────────────────────────────────────────────────────────────────────────┐
| OS           | Windows 10 Home                                                          |
| Version      | 2009 (Build: 22631)                                                      |
| ID           | 23H2                                                                     |
| Go Version   | go1.23.3                                                                 |
| Platform     | windows                                                                  |
| Architecture | amd64                                                                    |
| CPU          | 12th Gen Intel(R) Core(TM) i7-1255U                                      |
| GPU          | Intel(R) Iris(R) Xe Graphics (Intel Corporation) - Driver: 30.0.101.3118 |
| Memory       | 16GB                                                                     |
└─────────────────────────────────────────────────────────────────────────────────────────┘

# Dependencies
┌───────────────────────────────────────────────────────┐
| Dependency | Package Name | Status    | Version       |
| WebView2   | N/A          | Installed | 130.0.2849.80 |
| Nodejs     | N/A          | Installed | 22.11.0       |
| npm        | N/A          | Installed | 10.9.0        |
| *upx       | N/A          | Available |               |
| *nsis      | N/A          | Available |               |
└─────────────── * - Optional Dependency ───────────────┘

Additional context

No response
@ronen25 ronen25 added the Bug Something isn't working label Nov 17, 2024
@leaanthony
Copy link
Member

That's how Microsoft reports it! 😅 Crazy I know.

@leaanthony leaanthony closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2024
@ronen25 ronen25 mentioned this issue Nov 17, 2024
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Windows 11 identification in wails doctor ronen25/wails
2 participants
@leaanthony @ronen25