-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require AudioDecoderConfig.description
for channels > 2 with Opus?
#826
Comments
There's already a precedent for generating |
Generating headers seems reasonable, with a caveat: I'd support to generating headers for channel mapping families |
Is there a way to support Opus channel mapping families Also, I am wondering if there are implications for other codecs where multichannel is supported via IAMF. |
Thanks Bernard, I am just learning about channel mappings I've ran into the following issue trying to generate a Does it still make sense to generate a header in this case? |
I think you're right, I'm not sure what we're doing then. |
Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1915143 for the Gecko side. |
Just a note that this isn't supposed to return The idea here was to allow checking if a codec is supported, with some parameters, but not to require having bits of the media to check for support. e.g. if I want to know if a UA implement Flac decoding with Web Codecs (Flac being a codec that requires a In light of #826 (comment) (that we obviously ran into as well), Gecko is going to implement requiring a description for channels > 2, because as @tguilbert-google that's the only thing possible. Some WPTs are added to check this, what Gecko was doing was nonsensical. |
Those are good clarifications. I think Chrome's implementation needs to revisit some of its error messages, which suggest calling What about the following case:
The first case is justifiable to me, as we want to allow quick and easy checks and early fallbacks. |
I've always thought of it like what you describe. The line is a bit blurry, but generally if you need to instantiate a byte stream parser, you've crossed it. |
FWIW, Chrome is already parsing |
There's a middle ground in which UA are allowed to perform a more in-depth check. I think this is reasonable, and useful for authors. |
From the spec:
What is one supposed to do if they have a |
It doesn't exist. Opus is mono or stereo, and then you combine mono or stereo streams per https://datatracker.ietf.org/doc/html/rfc7845#section-5.1 and/or https://datatracker.ietf.org/doc/rfc8486/ to have a stream with more than 2 channels. |
Thanks for the explanation! I understand now that the audio tracks tagged |
I'm surfacing this issue, originally reported against Chromium's implementation.
The following fails on Chromium but works on Firefox
If the channel count is greater than 2 we can either:
{supported: false}
whenAudioDecoderConfig.description
isn't setextradata
behind the scenesIs this worth calling out in the spec, or adding a non-normative note?
@padenot, wdyt?
The text was updated successfully, but these errors were encountered: