Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text-4] text-spacing-trim is harmful for Yu Gothic UI (system-ui in Japanese Windows) #11074

Open
tats-u opened this issue Oct 22, 2024 · 10 comments

Comments

@tats-u
Copy link

tats-u commented Oct 22, 2024

#3658 (comment)

halt in Yu Gothic UI is broken. It causes broken disastrous rendering of brackets:

https://issues.chromium.org/issues/331123676?pli=1

https://twitter.com/search?q=https%3A%2F%2Ftawara-memo.hatenablog.com%2Fentry%2F2024%2F10%2F12%2F174432&src=typed_query
https://b.hatena.ne.jp/entry/s/tawara-memo.hatenablog.com/entry/2024/10/12/174432
https://twitter.com/shirouzu/status/1845400436678983704/quotes
https://twitter.com/tawara_san/status/1845023105288372415/quotes

e1a0b7396220-20240325
d589ebd147f6-20240325
Images from: https://zenn.dev/inaniwaudon/scraps/f224417d4c51ee (Japanese)

GZwtagyaAAAEbFh
Image from: https://twitter.com/shirouzu/status/1845400436678983704 (Japanese)

20241012165848
Image from: https://tawara-memo.hatenablog.com/entry/2024/10/12/174432 (Japanese)

As to https://tawara-memo.hatenablog.com/entry/2024/10/12/174432 (Japanese), the width of such brackets in Yu Gothic UI is 0 when halt is enabled.

20241012171303
Image from: https://tawara-memo.hatenablog.com/entry/2024/10/12/174432 (Japanese)

20241012172406
Image from: https://tawara-memo.hatenablog.com/entry/2024/10/12/174432 (Japanese)

image
https://codepen.io/tats-u/pen/MWNEJRN

We should detect broken fonts like Yu Gothic UI by checking the width of halt glyphs. If its width is less than 1/4 or 1/8 of the original width, halt of that glyph should be treated as broken.

@nt1m
Copy link
Member

nt1m commented Oct 22, 2024

@kojiishi
Copy link
Contributor

Thank you for reporting the issue and sorry to hear the trouble. It looks like the fix is on its way, please see https://crbug.com/331123676#comment7. /cc @alisonmaher

@tats-u
Copy link
Author

tats-u commented Oct 23, 2024

t looks like the fix is on its way,

I strongly doubt it. I have never heard Yu Gothic's GPOS has been fixed in 24H2. There is no reply from her or other employees since April.

@tats-u
Copy link
Author

tats-u commented Oct 23, 2024

Yu Gothic's palt is broken, too. How useless its GPOS is!
Shouldn't you think browsers should ignore the GPOS of such a low-quality font making fun of Japanese designers and users?

image

pwid had no effect so the GSUB has no problem. Only GPOS does.

@tats-u
Copy link
Author

tats-u commented Oct 23, 2024

It can cause DoS on a browser or WebView.

https://b.hatena.ne.jp/entry/4760513438625758112/comment/takinou0

鉤括弧を千個重ねても1こにしか見えないので、「これが無下限術式だ!」とか言って遊んでたら、同僚のteamsを異常終了させちゃって申し訳ない気持ちになったやつだ。遊んでたサラリーマンが悪いような気もするが……

I told Claude to translate it:

This is about that glitch - when I stacked a thousand corner brackets that all overlapped due to the bug, I was playing around saying "Behold the Unlimited Void technique!" but ended up accidentally crashing my colleague's Teams client. While I do feel guilty about it, maybe I'm also at fault for messing around as a salaryman...

@alisonmaher
Copy link
Collaborator

I strongly doubt it. I have never heard Yu Gothic's GPOS has been fixed in 24H2. There is no reply from her or other employees since April.

Apologies for the delayed response on the bug. Ali from the Windows has an update that he is planning to post in the bug shortly.

@alib-ms
Copy link

alib-ms commented Oct 23, 2024

Fixed! An update for the Yu Gothic font family has been checked in. This update addresses the issue where overlapping characters appeared with the UI components of the Yu Gothic font family in online environments.

Before:
image

After:
image

I’ll collaborate with the Windows Servicing team and the Office team to ensure these fonts are available across various endpoints. I’ll share the public availability date once we have a confirmed timeline.

@tats-u
Copy link
Author

tats-u commented Oct 23, 2024

Fixed! An update for the Yu Gothic font family has been checked in

I'm glad to know it, but can outsiders of Microsoft try this via some Insider channels today? Or can only employees do (just dogfooding phase)?
Also, was palt for hiragana & katakana fixed, too?

image

https://codepen.io/tats-u/pen/PoMOPyO

@alib-ms
Copy link

alib-ms commented Oct 24, 2024

We removed the 'halt' and 'palt' OpenType features from the UI components of the fonts.
image
No changes for the Yu Gothic, only Yu Gothic UI components were updated.

It's not in the insider build yet. I will be happy to share a private build of the font for testing purposes.

@tats-u
Copy link
Author

tats-u commented Oct 24, 2024

We removed the 'halt' and 'palt' OpenType features from the UI components of the fonts.

It's not a bad decision and good as a hotfix.
We might be able to keep the halt and palt GPOS of some punctuation marks in the Halfwidth and Fullwidth Form block (e.g. !?()[]{}). They work great in the current release:
It might be because it is a pain in the neck to inspect the entire content of GPOS that you chose to remove it.

image
https://codepen.io/tats-u/pen/GRVOWwY

It's not in the insider build yet. I will be happy to share a private build of the font for testing purposes.

I look forward a release for Insiders outside of your company.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants