Skip to content

Odd behavior inside the library. #60

@EliezerB123

Description

@EliezerB123

Hi! I was looking over the code as reference for writing a library for my private work, and I noticed something odd.

sticky-thing.directive.ts

It seems that this.sticky is always false if there's no scrollContainer.

Which means that if there's no container, then determineElementOffsets() won't remove sticky before doing its math.

Is this intended behavior?

Edit: Oh. I see. this.sticky controls whether it uses position:sticky or position:fixed. Okay. So it is working as intended....... Except why would you need to turn off position:sticky, but not position:fixed before running determineElementOffsets()?

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixingIssue is currently fixed.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions