-
Notifications
You must be signed in to change notification settings - Fork 27
Open
Labels
fixingIssue is currently fixed.Issue is currently fixed.
Description
Hi! I was looking over the code as reference for writing a library for my private work, and I noticed something odd.
sticky-thing.directive.ts
It seems that this.sticky is always false if there's no scrollContainer.
Which means that if there's no container, then determineElementOffsets() won't remove sticky before doing its math.
Is this intended behavior?
Edit: Oh. I see. this.sticky controls whether it uses position:sticky or position:fixed. Okay. So it is working as intended....... Except why would you need to turn off position:sticky, but not position:fixed before running determineElementOffsets()?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
fixingIssue is currently fixed.Issue is currently fixed.