Skip to content

Commit c1f1613

Browse files
committed
Removed submodule for HAP-NodeJS and moved to NPM
It seemed to be easier all around to use NPM to manage the dependancy on HAP-NodeJS. This PR removes the submodule, and adjusts the paths of all checked in shims to reference the NPM module instead. I also updated the documentation to reflect the simpler install ;)
1 parent 4332af6 commit c1f1613

21 files changed

+23
-30
lines changed

.gitmodules

-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +0,0 @@
1-
[submodule "lib/HAP-NodeJS"]
2-
path = lib/HAP-NodeJS
3-
url = https://github.com/KhaosT/HAP-NodeJS.git

README.md

+2-6
Original file line numberDiff line numberDiff line change
@@ -53,17 +53,13 @@ Additionally, the shims I've created implement the bare minimum of HomeKit neede
5353

5454
# Getting Started
5555

56-
OK, if you're still excited enough about ordering Siri to make your coffee (which, who wouldn't be!) then here's how to set things up. First, clone this repo and also init submodules to grab the [HAP-NodeJS](https://github.com/KhaosT/HAP-NodeJS) project which isn't in npm. You'll also need to run `npm install` on HAP-NodeJS:
56+
OK, if you're still excited enough about ordering Siri to make your coffee (which, who wouldn't be!) then here's how to set things up. First, clone this repo:
5757

5858
$ git clone https://github.com/nfarina/homebridge.git
5959
$ cd homebridge
60-
$ git submodule init
61-
$ git submodule update
62-
$ npm install
63-
$ cd lib/HAP-NodeJS
6460
$ npm install
6561

66-
**Node**: You'll need to have NodeJS version 0.12.x or better installed for `HAP-NodeJS` to load.
62+
**Node**: You'll need to have NodeJS version 0.12.x or better installed for required submodule `HAP-NodeJS` to load.
6763

6864
Now you should be able to run the homebridge server:
6965

accessories/AD2USB.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
1+
var types = require("HAP-NodeJS/accessories/types.js");
22
var AD2USB = require('ad2usb');
33
var CUSTOM_PANEL_LCD_TEXT_CTYPE = "A3E7B8F9-216E-42C1-A21C-97D4E3BE52C8";
44

accessories/Carwings.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
1+
var types = require("HAP-NodeJS/accessories/types.js");
22
var carwings = require("carwingsjs");
33

44
function CarwingsAccessory(log, config) {

accessories/ELKM1.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
1+
var types = require("HAP-NodeJS/accessories/types.js");
22
var elkington = require("elkington");
33

44
function ElkM1Accessory(log, config) {

accessories/HomeMatic.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
1+
var types = require("HAP-NodeJS/accessories/types.js");
22
var request = require("request");
33

44
function HomeMatic(log, config) {

accessories/Http.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
1+
var types = require("HAP-NodeJS/accessories/types.js");
22
var request = require("request");
33

44
function HttpAccessory(log, config) {

accessories/LiftMaster.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
1+
var types = require("HAP-NodeJS/accessories/types.js");
22
var request = require("request");
33

44
// This seems to be the "id" of the official LiftMaster iOS app

accessories/Lockitron.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
1+
var types = require("HAP-NodeJS/accessories/types.js");
22
var request = require("request");
33

44
function LockitronAccessory(log, config) {

accessories/Sonos.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
1+
var types = require("HAP-NodeJS/accessories/types.js");
22
var sonos = require('sonos');
33

44
function SonosAccessory(log, config) {

accessories/WeMo.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
1+
var types = require("HAP-NodeJS/accessories/types.js");
22
var wemo = require('wemo');
33

44
// extend our search timeout from 5 seconds to 60

accessories/X10.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
1+
var types = require("HAP-NodeJS/accessories/types.js");
22
var request = require("request");
33

44
function X10(log, config) {

accessories/XfinityHome.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
1+
var types = require("HAP-NodeJS/accessories/types.js");
22
var request = require("request");
33
var xmldoc = require("xmldoc");
44

app.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,10 @@ function loadPlatforms() {
101101
//
102102

103103
// Pull in required HAP-NodeJS stuff
104-
var accessory_Factor = new require("./lib/HAP-NodeJS/Accessory.js");
105-
var accessoryController_Factor = new require("./lib/HAP-NodeJS/AccessoryController.js");
106-
var service_Factor = new require("./lib/HAP-NodeJS/Service.js");
107-
var characteristic_Factor = new require("./lib/HAP-NodeJS/Characteristic.js");
104+
var accessory_Factor = new require("HAP-NodeJS/Accessory.js");
105+
var accessoryController_Factor = new require("HAP-NodeJS/AccessoryController.js");
106+
var service_Factor = new require("HAP-NodeJS/Service.js");
107+
var characteristic_Factor = new require("HAP-NodeJS/Characteristic.js");
108108

109109
// Each accessory has its own little server. We'll need to allocate some ports for these servers
110110
var nextPort = 51826;

lib/HAP-NodeJS

-1
This file was deleted.

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"url": "git://github.com/nfarina/homebridge.git"
1111
},
1212
"dependencies": {
13+
"hap-nodejs": "git+https://github.com/khaost/HAP-NodeJS",
1314
"ad2usb": "git+https://github.com/alistairg/node-ad2usb.git#local",
1415
"request": "2.49.x",
1516
"node-persist": "0.0.x",

platforms/Domoticz.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
// When you attempt to add a device, it will ask for a "PIN code".
2626
// The default code for all HomeBridge accessories is 031-45-154.
2727
//
28-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
28+
var types = require("HAP-NodeJS/accessories/types.js");
2929
var request = require("request");
3030

3131
function DomoticzPlatform(log, config){

platforms/ISY.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
1+
var types = require("HAP-NodeJS/accessories/types.js");
22
var xml2js = require('xml2js');
33
var request = require('request');
44
var util = require('util');

platforms/PhilipsHue.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ var hue = require("node-hue-api"),
3333
HueApi = hue.HueApi,
3434
lightState = hue.lightState;
3535

36-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
36+
var types = require("HAP-NodeJS/accessories/types.js");
3737

3838
function PhilipsHuePlatform(log, config) {
3939
this.log = log;

platforms/SmartThings.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// SmartThings JSON API SmartApp required
22
// https://github.com/jnewland/SmartThings/blob/master/JSON.groovy
33
//
4-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
4+
var types = require("HAP-NodeJS/accessories/types.js");
55
var request = require("request");
66

77
function SmartThingsPlatform(log, config){

platforms/Wink.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var types = require("../lib/HAP-NodeJS/accessories/types.js");
1+
var types = require("HAP-NodeJS/accessories/types.js");
22
var wink = require('wink-js');
33

44
var model = {

0 commit comments

Comments
 (0)