Skip to content

Commit 69b131c

Browse files
javachemeta-codesync[bot]
authored andcommitted
Clear out mTagToSynchronousMountProps on surface stop (facebook#54693)
Summary: Pull Request resolved: facebook#54693 SurfaceMountingManager stays around even after the surface is stopped - we need to clean these up. Changelog: [Internal] Reviewed By: zeyap Differential Revision: D87875316 fbshipit-source-id: f47a8d34bc9b9f43071c9c113bac1a85a5171748
1 parent f472ef9 commit 69b131c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public class SurfaceMountingManager {
8383
new ConcurrentHashMap<>(); // any thread
8484
private final Queue<MountItem> mOnViewAttachMountItems = new ArrayDeque<>();
8585
private JSResponderHandler mJSResponderHandler;
86-
private ViewManagerRegistry mViewManagerRegistry;
86+
private final ViewManagerRegistry mViewManagerRegistry;
8787
private RootViewManager mRootViewManager;
8888
private MountItemExecutor mMountItemExecutor;
8989

@@ -336,6 +336,7 @@ public void stopSurface() {
336336
mMountItemExecutor = null;
337337
mThemedReactContext = null;
338338
mOnViewAttachMountItems.clear();
339+
mTagToSynchronousMountProps.clear();
339340

340341
FLog.e(TAG, "Surface [" + mSurfaceId + "] was stopped on SurfaceMountingManager.");
341342
};

0 commit comments

Comments
 (0)