[BUG] download_filtered_tableau_image(): having certain special characters (e.g. :) in filter values causes error

[tkr231]

Issue Type

• Bug Report
• Feature Request
• Question/Support

Current Behavior

When a filter value contains any forbidden characters for filenames in windows (e.g. : or /) download_filtered_tableau_image() is unable to save the downloaded image

Expected Behavior

Ignore forbidden filename characters when trying to save the file. Make clear in the documentation that this theoretically could result
in overwriting already downloaded images, in case the only difference in filter values are the aformentioned characters.

Steps to Reproduce (for bugs)

1. Supply a value with for instance ':' in the dataframe supplied at the df argument of the download_filtered_tableau_image() function

Context

See above.

Your Environment

vvtableau 0.6.0
R version 4.4.1

Possible Solution

Ignore forbidden filename characters when trying to save the file. Make clear in the documentation that this theoretically could result
in overwriting already downloaded images, in case the only difference in filter values are the aformentioned characters.

[tin900]

Hi @tkr231

It seems the issue arises from the underlying function row_to_name(). We could look into sanitizing the names by replacing such characters with an underscore.

You can test out the function on the associated branch for the changes. See also pull request #11