Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Migrating image source from Docker Hub to Vultr Container Registry #266

Open
JoeyC-Dev opened this issue Dec 17, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@JoeyC-Dev
Copy link
Contributor

JoeyC-Dev commented Dec 17, 2024

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Effective November 2, 2020, download rate limits apply to anonymous and authenticated requests to Docker Hub from Docker Free Plan accounts and are enforced by IP address and Docker ID, respectively.

The actual limit is 10 pulls per IP per hour.
image

Currently, in manifest, we can see it is using Docker Hub as the source.

image: vultr/vultr-csi:v0.13.3

Describe the solution you'd like
A clear and concise description of what you want to happen.

I understand we can mitigate this issue by:

  1. Setting kubernetes.io/dockerconfigjson
  2. Pre-download the image and upload to own private container registry

However, can we do it better by migrating the image source to Vultr Container Registry? It will be better if this is maintained by official and I don't have to replace the image source every time in the latest manifest when vultr-csi is updated.

Additional context
I am not expecting VKE becomes another CKE or AKS, but hope we can have better process on maintaining.
If there is an official online tool to replace image source quickly (and warned the user the potential issue relatively), so user can copy the final installation yaml/shell and paste to execute it, it is still acceptable.

@JoeyC-Dev JoeyC-Dev added the enhancement New feature or request label Dec 17, 2024
@JoeyC-Dev
Copy link
Contributor Author

Hmmm, it is interesting that I am getting this for feature request?
https://github.com/vultr/vultr-csi/actions/runs/12366867251/job/34514261480#step:3:9

@happytreees
Copy link
Contributor

Hey @JoeyC-Dev , you can disregard the failed action, but we will get it fixed so it doesn't continue.

Regarding this request, we can definitely add this to a public Vultr CR repository to mitigate issues with pull limits. We will work on getting this implemented.

@happytreees happytreees self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants