feat: add prefer-use-template-ref rule #2554
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
requested changes
Sep 17, 2024
ota-meshi
requested changes
Sep 18, 2024
| <div ref="root" /> | ||
| </template> | ||
|
|
||
| <script> |
There was a problem hiding this comment.
If it is a <script setup> test, the setup attribute is required.
Suggested change
| <script> | |
| <script setup> |
Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
Co-authored-by: Flo Edelmann <[email protected]>
This comment was marked as spam.
This comment was marked as spam.
@maxfrees I will split it to 2 PRs as @ota-meshi suggested. Sorry for the delay, I was not able to get to it recently, will try to finish at least the first part this weekend, most of it is already done. |
|
@FloEdelmann @ota-meshi Implemented all of your feedback. 🙂 |
FloEdelmann
reviewed
Nov 4, 2024
| data() { | ||
| return { | ||
| label: ref(), | ||
| label: ref(this.defaultLabel), | ||
| labelElem: ref(), |
There was a problem hiding this comment.
Are refs actually supported by Vue in Option API's data like this?
There was a problem hiding this comment.
It doesn't break but Vue acts like the ref isn't there at all, it will simply unwrap the value. I wanted to prove that it works even in such a case, should I remove the test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2549