Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-core): using a user-provided key in v-if template element. #11728

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix(compiler-core): using a user-provided key in v-if template element. #11728

wants to merge 8 commits into from

Conversation

linzhe141
Copy link
Contributor

@linzhe141 linzhe141 commented Aug 28, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 99.9 kB 37.6 kB 33.9 kB
vue.global.prod.js 159 kB (+172 B) 57.6 kB (+62 B) 51.2 kB (+66 B)

Usages

Name Size Gzip Brotli
createApp 55.1 kB 21.2 kB 19.4 kB
createSSRApp 59.1 kB 22.9 kB 20.8 kB
defineCustomElement 59.8 kB 22.7 kB 20.7 kB
overall 68.8 kB 26.3 kB 23.9 kB

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 28, 2024 •
edited
Loading

commit: 551ac25

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11728

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11728

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11728

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11728

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11728

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11728

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11728

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11728

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11728

vue

pnpm add https://pkg.pr.new/vue@11728

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11728

Open in Stackblitz

@linzhe141 linzhe141 marked this pull request as draft August 28, 2024 05:09
@linzhe141 linzhe141 marked this pull request as ready for review August 28, 2024 06:02
@linzhe141 linzhe141 marked this pull request as draft August 28, 2024 06:04
@linzhe141 linzhe141 marked this pull request as ready for review August 28, 2024 06:13
edison1105
edison1105 reviewed Aug 28, 2024
View reviewed changes
packages/compiler-core/__tests__/transforms/vIf.spec.ts
],
},
})
const {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest splitting it into two tests

@edison1105 edison1105 added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews labels Aug 28, 2024
@skirtles-code
Copy link
Contributor

I just gave this a try, but it seems that the prop hoisting breaks it:

Error: $setup is not defined

edison1105
edison1105 reviewed Aug 29, 2024
View reviewed changes
packages/compiler-core/__tests__/transforms/vIf.spec.ts
})
})

test('template is static key with v-if', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test('template is static key with v-if', () => {
test('template v-if + static key', () => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 left review comments

Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews
Projects
None yet
Milestone
No milestone
3 participants
@linzhe141 @skirtles-code @edison1105