-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Teleport): hydrate disabled Teleport with undefined target #11235
base: main
Are you sure you want to change the base?
Conversation
…eleport should use the node of nextSibling
Hello, thanks for the PR. Is there any chance it will get merged? |
@@ -406,6 +406,21 @@ function hydrateTeleport( | |||
} | |||
updateCssVars(vnode) | |||
} | |||
if (!target && isTeleportDisabled(vnode.props)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!target && isTeleportDisabled(vnode.props)) { | |
else if (isTeleportDisabled(vnode.props)) { | |
if (vnode.shapeFlag & ShapeFlags.ARRAY_CHILDREN) { | |
vnode.anchor = hydrateChildren( | |
nextSibling(node), | |
vnode, | |
parentNode(node)!, | |
parentComponent, | |
parentSuspense, | |
slotScopeIds, | |
optimized, | |
) | |
vnode.targetStart = node | |
vnode.targetAnchor = nextSibling(node) | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to extract a hydrateDisabledTeleport
method.
Could you please add a test case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review, I will improve it
Size ReportBundles
Usages
|
bd3ac0e
to
49581b7
Compare
Sorry for the bump, but is there any chance it will get merged? Thanks a lot for your work @linzhe141 🙏 |
Maybe the current modification is not correct, so it may not be merged. |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
@vue/compiler-core
@vue/compiler-sfc
@vue/compiler-dom
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/shared
@vue/server-renderer
vue
@vue/compat
commit: |
close #11230