Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-vapor): fix slots render level mess up #241

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Doctor-wu
Copy link
Member

@Doctor-wu Doctor-wu commented Jun 19, 2024

close #242

  • fix runtime
  • add test case

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit d57c4c8
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/66fa45758d924600085f113b
😎 Deploy Preview https://deploy-preview-241--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit d57c4c8
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/66fa45757b9a8c0008ec05c1
😎 Deploy Preview https://deploy-preview-241--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jun 19, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 81.9 kB 28.5 kB 25.1 kB
compiler-vapor.global.prod.js 59 kB 19.7 kB 17.8 kB
runtime-dom.global.prod.js 101 kB 38 kB 34.2 kB
runtime-vapor.global.prod.js 46.2 kB (+206 B) 17.2 kB (+86 B) 15.8 kB (+67 B)
vue-vapor.global.prod.js 102 kB (+206 B) 35.3 kB (+75 B) 31.8 kB (+77 B)
vue.global.prod.js 160 kB 58 kB 51.6 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.4 kB 19 kB 17.3 kB
createApp 56 kB 21.4 kB 19.6 kB
createSSRApp 60 kB 23.1 kB 21.1 kB
defineCustomElement 60.8 kB 23 kB 21 kB
vapor 46.8 kB (+206 B) 17.5 kB (+84 B) 16 kB (+66 B)
overall 69.7 kB 26.5 kB 24.1 kB

@Doctor-wu Doctor-wu marked this pull request as draft June 19, 2024 14:43
@LittleSound
Copy link
Member

I have addressed a similar issue in PR #227. You can refer to the implementation of the normalizeSlotProps function.

I hope this information helps you solve the problem!

@Doctor-wu Doctor-wu marked this pull request as ready for review June 23, 2024 09:11
@Doctor-wu
Copy link
Member Author

Preview Demo

Copy link

pkg-pr-new bot commented Aug 8, 2024

commit: ea2e2a4

@vue/compiler-core

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-core@241

@vue/compiler-dom

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-dom@241

@vue/compiler-sfc

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-sfc@241

@vue/compiler-ssr

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-ssr@241

@vue/compiler-vapor

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compiler-vapor@241

@vue/reactivity

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/reactivity@241

@vue/runtime-core

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-core@241

@vue/runtime-dom

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-dom@241

@vue/runtime-shared

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-shared@241

@vue/runtime-vapor

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/runtime-vapor@241

@vue/server-renderer

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/server-renderer@241

@vue/shared

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/shared@241

vue

pnpm add https://pkg.pr.new/vuejs/core-vapor/vue@241

@vue/compat

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/compat@241

@vue/vapor

pnpm add https://pkg.pr.new/vuejs/core-vapor/@vue/vapor@241

Open in Stackblitzplayground

@moushicheng
Copy link
Contributor

moushicheng commented Aug 28, 2024

look good👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slots level mess up
4 participants