Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs about Typos and Grammatical errors are not considered in the PR Template #3850

Open
Cyebukayire opened this issue Jan 11, 2022 · 5 comments

Comments

@Cyebukayire
Copy link
Contributor

Cyebukayire commented Jan 11, 2022

I thought there might be a type called " [ ] Chore " with a required description of the changes that have been made in the PR.
but there are only " [ ] Fix " and " [ ] Feature " types to choose from with check boxed about Apps/Websites & links.
I guess these don't apply in the case of Typos and Grammatical errors.

Was it intentional or can one add it? I just need to know

@Scrum
Copy link
Collaborator

Scrum commented Jan 12, 2022

You make corrections hence this point " [ ] Fix "

Too many statuses make you think about the correctness of the choice, you have only two options, either you introduce something new or you fix something

@Cyebukayire
Copy link
Contributor Author

Are Grammatical error corrections considered as fixes? I thought fixes relate to code changes that affect the system functionality

@Scrum
Copy link
Collaborator

Scrum commented Jan 12, 2022

Are Grammatical error corrections considered as fixes? I thought fixes relate to code changes that affect the system functionality

Grammar errors as code but not for machines)

@Cyebukayire
Copy link
Contributor Author

ohhh it makes sense
so, how about the Grammatical errors in files like README?

@Scrum
Copy link
Collaborator

Scrum commented Jan 13, 2022

so, how about the Grammatical errors in files like README?

Sounds very good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants