From 908e35f6afe38dfe0a807227ce374ef97f729fd3 Mon Sep 17 00:00:00 2001 From: Andrew Kazakov Date: Mon, 14 Jul 2025 13:17:50 +0300 Subject: [PATCH 1/2] fix: disallow extra properties in rule options --- src/rules/alt-text.ts | 3 ++- src/rules/anchor-has-content.ts | 3 ++- src/rules/form-control-has-label.ts | 3 ++- src/rules/heading-has-content.ts | 3 ++- src/rules/interactive-supports-focus.ts | 3 ++- src/rules/label-has-for.ts | 9 ++++++--- src/rules/media-has-caption.ts | 3 ++- 7 files changed, 18 insertions(+), 9 deletions(-) diff --git a/src/rules/alt-text.ts b/src/rules/alt-text.ts index d2b9e05f..c0d6e2d5 100644 --- a/src/rules/alt-text.ts +++ b/src/rules/alt-text.ts @@ -91,7 +91,8 @@ const rule: Rule.RuleModule = { } }), {} - ) + ), + additionalProperties: false } ] }, diff --git a/src/rules/anchor-has-content.ts b/src/rules/anchor-has-content.ts index 104920b7..af86b662 100644 --- a/src/rules/anchor-has-content.ts +++ b/src/rules/anchor-has-content.ts @@ -35,7 +35,8 @@ const rule: Rule.RuleModule = { type: "array", items: { type: "string" } } - } + }, + additionalProperties: false } ] }, diff --git a/src/rules/form-control-has-label.ts b/src/rules/form-control-has-label.ts index 55ab71ec..e2bcb144 100644 --- a/src/rules/form-control-has-label.ts +++ b/src/rules/form-control-has-label.ts @@ -83,7 +83,8 @@ const rule: Rule.RuleModule = { }, uniqueItems: true } - } + }, + additionalProperties: false } ] }, diff --git a/src/rules/heading-has-content.ts b/src/rules/heading-has-content.ts index db6bd616..b81c5308 100644 --- a/src/rules/heading-has-content.ts +++ b/src/rules/heading-has-content.ts @@ -36,7 +36,8 @@ const rule: Rule.RuleModule = { type: "array", items: { type: "string" } } - } + }, + additionalProperties: false } ] }, diff --git a/src/rules/interactive-supports-focus.ts b/src/rules/interactive-supports-focus.ts index d3871ff6..95ba4a19 100644 --- a/src/rules/interactive-supports-focus.ts +++ b/src/rules/interactive-supports-focus.ts @@ -108,7 +108,8 @@ const rule: InteractiveSupportsFocus = { uniqueItems: true, additionalItems: false } - } + }, + additionalProperties: false } ] }, diff --git a/src/rules/label-has-for.ts b/src/rules/label-has-for.ts index 2af4c386..de99d00a 100644 --- a/src/rules/label-has-for.ts +++ b/src/rules/label-has-for.ts @@ -116,7 +116,8 @@ const rule: Rule.RuleModule = { uniqueItems: true } }, - required: ["some"] + required: ["some"], + additionalProperties: false }, { type: "object", @@ -130,14 +131,16 @@ const rule: Rule.RuleModule = { uniqueItems: true } }, - required: ["every"] + required: ["every"], + additionalProperties: false } ] }, allowChildren: { type: "boolean" } - } + }, + additionalProperties: false } ] }, diff --git a/src/rules/media-has-caption.ts b/src/rules/media-has-caption.ts index 5d544683..c5cb1824 100644 --- a/src/rules/media-has-caption.ts +++ b/src/rules/media-has-caption.ts @@ -46,7 +46,8 @@ const rule: Rule.RuleModule = { type: "array", items: { type: "string" } } - } + }, + additionalProperties: false } ] }, From ff1f0f9ad6eae5b1a3fc5d1433158dc2a8a3e667 Mon Sep 17 00:00:00 2001 From: Andrew Kazakov Date: Mon, 14 Jul 2025 13:18:28 +0300 Subject: [PATCH 2/2] fix: no-distracting-elements rule schema --- src/rules/no-distracting-elements.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rules/no-distracting-elements.ts b/src/rules/no-distracting-elements.ts index cd13969c..43169a71 100644 --- a/src/rules/no-distracting-elements.ts +++ b/src/rules/no-distracting-elements.ts @@ -22,7 +22,7 @@ const rule: Rule.RuleModule = { schema: [ { type: "object", - elements: { + additionalProperties: { type: "array", items: { type: "string",