Skip to content

Ssh cleanup #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Ssh cleanup #7

wants to merge 30 commits into from

Conversation

@vthiebaut10
Copy link
Owner

@vthiebaut10 vthiebaut10 commented Oct 26, 2021

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

bagajjal
bagajjal reviewed Oct 27, 2021
View reviewed changes
bagajjal
bagajjal reviewed Oct 27, 2021
View reviewed changes
bagajjal
bagajjal reviewed Oct 27, 2021
View reviewed changes
bagajjal
bagajjal reviewed Oct 27, 2021
View reviewed changes
bagajjal
bagajjal reviewed Oct 27, 2021
View reviewed changes
bagajjal
bagajjal reviewed Oct 27, 2021
View reviewed changes
bagajjal
bagajjal reviewed Oct 27, 2021
View reviewed changes
bagajjal
bagajjal reviewed Oct 27, 2021
View reviewed changes
bagajjal
bagajjal reviewed Oct 27, 2021
View reviewed changes
bagajjal
bagajjal suggested changes Oct 27, 2021
View reviewed changes
Copy link

@bagajjal bagajjal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

bagajjal
bagajjal reviewed Nov 2, 2021
View reviewed changes
bagajjal
bagajjal reviewed Nov 2, 2021
View reviewed changes
bagajjal
bagajjal reviewed Nov 2, 2021
View reviewed changes
bagajjal
bagajjal reviewed Nov 2, 2021
View reviewed changes
bagajjal
bagajjal reviewed Nov 2, 2021
View reviewed changes
bagajjal
bagajjal reviewed Nov 2, 2021
View reviewed changes
bagajjal
bagajjal reviewed Nov 2, 2021
View reviewed changes
bagajjal
bagajjal reviewed Nov 2, 2021
View reviewed changes
bagajjal
bagajjal reviewed Nov 2, 2021
View reviewed changes
bagajjal
bagajjal reviewed Nov 2, 2021
View reviewed changes
src/ssh/azext_ssh/custom.py
os.makedirs(credentials_folder)
public_key_file = os.path.join(credentials_folder, "id_rsa.pub")
private_key_file = os.path.join(credentials_folder, "id_rsa")
ssh_utils.create_ssh_keyfile(private_key_file)
Copy link

@bagajjal bagajjal Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the id_rsa, id_rsa.pub already exists in the credentials_folder?

bagajjal
bagajjal suggested changes Nov 2, 2021
View reviewed changes
Copy link

@bagajjal bagajjal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

bagajjal
bagajjal reviewed Nov 3, 2021
View reviewed changes
bagajjal
bagajjal reviewed Nov 3, 2021
View reviewed changes
bagajjal
bagajjal reviewed Nov 3, 2021
View reviewed changes
bagajjal
bagajjal reviewed Nov 3, 2021
View reviewed changes
vthiebaut10 and others added 15 commits November 3, 2021 19:03
vthiebaut10 pushed a commit that referenced this pull request Oct 22, 2024
@blackchoey @jukasper
apic-extension GA release (Azure#7677)
dcee6ba 
* build: add cicd pipeline (#7)

* build: move update version logic to workflow (#8)

* build: Run CI on multiple python version (Azure#38)

* build: Run CI in Python 3.8-3.11

* build: remove pull request event for CI to avoid duplicate runs

* test: add test cases for commands (Azure#40)

* fix: error when register API with long description spec (Azure#41)

* test: add test cases for optional parameters (Azure#42)

* feat!: remove file name param (Azure#43)

* fix: error not thrown when import spec with >3MB file (Azure#44)

* feat!: remove state param for deployment commands (Azure#46)

* fix: API title created by register command is not same with provided spec (Azure#47)

* feat!: redesign parameters to specify APIM instance for import-from-apim command (Azure#45)

* test: clean up legacy test cases (Azure#48)

* test: add test cases for command examples (Azure#49)

* docs: update help message per feedback (Azure#50)

* build: bump version to 1.0.0 and add changelog (Azure#51)

* fix: some parameters should be required in import-specification and deployment command (Azure#53)

* feat!: rename parameter names to align with other Azure CLI command experience (Azure#52)

* test: enable test for import-from-apim (Azure#54)

* test: fix show service test case (Azure#55)

* docs: update changelog for 1.0.0 (Azure#56)

* Update HISTORY.rst - jukasper

updated changelog

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

* docs: update readme for apic-extension (#57)

* fix: cannot run create command against existing resource (Azure#58)

* fix: cannot run create command against existing resource

* style: fix style

* build: remove cicd pipeline (Azure#59)

* build: resolve review comments (Azure#60)

---------

Co-authored-by: Julia Kasper <[email protected]>
vthiebaut10 pushed a commit that referenced this pull request Oct 22, 2024
@frankqianms @blackchoey @jukasper
apic-extension 1.1.0 release (Azure#8118)
d5be14f 
* build: add cicd pipeline (#7)

* build: move update version logic to workflow (#8)

* build: Run CI on multiple python version (Azure#38)

* build: Run CI in Python 3.8-3.11

* build: remove pull request event for CI to avoid duplicate runs

* refactor: add apic api update example

* tests: add test case

* fix: fix style

* fix: fix test case

* fix: fix test case

* fix: fix test case & add recording

* fix: remove bad command prefix

* refactor: optimize test case code

* refactor: remove duplicate example for apic create

* fix: fix style

* feat: add examples for create & update apic service with system assigned identity

* fix: fix external doc extracting bug in spec

* fix: remove extra print

* fix: fix style

* fix: fix style

* fix: fix style

* fix: fix style

* tests: fix test case

* refactor: remove external docs from tags

* tests: update test case

* refactor: remove summary setting in api register

* feat: support custom metadata export only

* fix: fix test case

* tests: add test case

* fix: fix arg type

* refactor: add help example

* fix: fix bad logic of link format

* refactor: remove extra example

* refactor: update example

* doc: update 1.0.1 release history

* refactor: change note style

* fix: fix

* fix: remove breaking change label

* build: bump version to 1.1.0

* Update V1.1.0 history (Azure#71)

* Update HISTORY.rst

* Update HISTORY.rst

* Update HISTORY.rst

---------

Co-authored-by: Julia Kasper <[email protected]>

* test: fix test cases

* build: remove files to get ready for release

---------

Co-authored-by: Chaoyi Yuan <[email protected]>
Co-authored-by: Julia Kasper <[email protected]>
vthiebaut10 pushed a commit that referenced this pull request Jun 27, 2025
@frankqianms @blackchoey
build: apic-extension 1.2.0b1 release (Azure#8411)
7f9035b 
* build: add cicd pipeline (#7)

* build: move update version logic to workflow (#8)

* build: Run CI on multiple python version (Azure#38)

* build: Run CI in Python 3.8-3.11

* build: remove pull request event for CI to avoid duplicate runs

* feat: enable openapi spec from url in api register (Azure#74)

* feat: enable openapi spec from url in api register

* refactor: set spec definition as link format when link provided

* fix: fix style

* test: add error handling case for testing invalid spec url

* fix: fix test case

* fix: use 404 response url

* test: update case

* test: update test case

* refactor: update error logic

* test: update test case to setup live test pipeline (Azure#76)

* test: update test case to setup live test pipeline (Azure#75)

* test: update test case

* update

* .

* .

* .

* .

* .

* .

* .

* .

* .

* .

* .

* test: update test case

* refactor: enable both identity

* fix: bad if else

* fix: fix bad parameter

* refactor: add example (Azure#77)

* refactor: add example

* fix: update params

* fix: bad api id

* refactor: add @filename.json examples (Azure#78)

* refactor: add example

* fix: update params

* fix: bad api id

* refactor: add @filename.json examples

* refactor: update

* refactor: add error handling (Azure#79)

* refactor: add error handling

* refactor: catch internal error

* fix: revert the change

* feat: support APIM/APIC sync (Azure#80)

* feat: add APIM/APIC sync commands

* feat: rename apim to azure-api-management

* style: fix code style

* fix: sync property names with new API spec

* Revert "fix: sync property names with new API spec"

This reverts commit 04da67e.

---------

Co-authored-by: frankqianms <[email protected]>

* feat: resolve feedback and fix examples (Azure#82)

* feat: resolve feedback and fix examples

* style: fix code style

* feat: amazon api gateway sync (Azure#81)

* feat: add APIM/APIC sync commands

* feat: rename apim to azure-api-management

* style: fix code style

* fix: sync property names with new API spec

* feat: add aws api gateway sync command

* Revert "fix: sync property names with new API spec"

This reverts commit 04da67e.

* refactor: add amazonApiGatewaySource

* refactor: refactoring apim sync and amazon sync

* refactor: refactor cmd structure to make apim and aws sync seperated

* fix: remove log print

* chore: generate new cmds

* refactor: update version and remove import

* feat: add `apic integration create amazon-api-gateway`

* fix: style

* fix: change query param api-version

* revert changes in _delete.py

* fix: some neede fixs

* fix: add the help sentence

* refactor: make params clear

* refactor: handle msi-resource-id

* refacor: revert flatten of apim resource

* fix: use 06-01-preiew currently

* fix: style

* refactor: arg groups

* fix: bad short param name

* chore: re-generate

* fix: old resource_id name

* chore: arg group

* chore: naming

* fix: fix according to comments

* chore: update

* fix: style

---------

Co-authored-by: Chaoyi Yuan <[email protected]>

* feat: add import amazon-api-gateway cmd (Azure#83)

* feat: add import amazon-api-gateway cmd

* feat: change arg group and update parameter name

---------

Co-authored-by: Chaoyi Yuan <[email protected]>

* fix: use older version API (Azure#84)

* feat: rename command and param names (Azure#85)

* feat: rename command and param names

* doc: update comments

* doc: update sample

* test: add test case for sync cmd `apic integration create apim` and `apic integration create aws` (Azure#86)

* test: add test case for apim sync

* refactor: refactor for apim preparer

* refactor: refactoring case and utils, optimize checkers

* chore: remove print and add explaination

* refactor: rename file

* fix: try to fix error determing the version

* revert: Remove specific azure-cli and azure-core installations

* test: add aws sync testcase (Azure#87)

* test: add test case for aws sync command

* fix: remove key value

* fix: remove pip install

* chore: renaming constants

* refactor: update the utils and test case

* refactor: updated

* fix: workaround for urllib3 package (Azure#88)

* Revert "fix: workaround for urllib3 package (Azure#88)" (Azure#90)

This reverts commit 1d508f4.

* build: 1.2.0 beta 1 release

* build: remove CI and CD files

* doc: improve history

* fix: set extention version to be preview

* refactor: integration examples and bad example for `apic update` (Azure#91)

* refactor: integration examples

* fix: apic update example

* chore: update log

* test: add import-aws case and modify region

---------

Co-authored-by: Chaoyi Yuan <[email protected]>
Co-authored-by: Chaoyi Yuan <[email protected]>
vthiebaut10 pushed a commit that referenced this pull request Jun 27, 2025
@bavneetsingh16 @mayankagg9722 @bragi92
[k8s-extension] Update extension CLI to v1.6.5 (Azure#8814)
0ba8c45 
* add pester tests for k8s-extension

* Adding CLI Configuration for DisableInformerCache Flag (#2)

This is required for our helm charts where customers can opt to change the caching behaviour during restore.

* fix testcases for nodepool image issues (#5)

* update readme and version release notes (#6)

* fix: simplify logic and enable correct recording rule groups for managed prom extension (#7)

* remove test cases specific to fork repo

---------

Co-authored-by: Bavneet Singh <[email protected]>
Co-authored-by: Mayank Aggarwal <[email protected]>
Co-authored-by: bragi92 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bagajjal bagajjal bagajjal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vthiebaut10 @bagajjal