From ea269b7c0037bf2ba48fc44fb775f3c8ca4645c7 Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Thu, 14 Nov 2024 22:35:44 +0100 Subject: [PATCH] rubocop: Use voxpupuli-rubocop --- .github/workflows/tests.yaml | 14 + .rubocop.yml | 708 +------------------------- .rubocop_todo.yml | 951 +++++++++++++++++++++++++++++++++++ Rakefile | 20 +- onceover.gemspec | 1 + 5 files changed, 978 insertions(+), 716 deletions(-) create mode 100644 .rubocop_todo.yml diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index 38272d5..9430a72 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -7,6 +7,19 @@ on: - master jobs: + rubocop: + env: + BUNDLE_WITHOUT: release + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - name: Install Ruby ${{ matrix.ruby }} + uses: ruby/setup-ruby@v1 + with: + ruby-version: "3.3" + bundler-cache: true + - name: Run Rubocop + run: bundle exec rake rubocop test: strategy: fail-fast: false @@ -42,6 +55,7 @@ jobs: tests: needs: + - rubocop - test runs-on: ubuntu-latest name: Test suite diff --git a/.rubocop.yml b/.rubocop.yml index 010ad0f..12e57db 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,705 +1,5 @@ -AllCops: - TargetRubyVersion: 2.4 # this should match the oldest version in .github/workflows/tests.yaml's matrix - NewCops: enable - Include: - - "lib/**/*.rb" - - "ext/**/*.rb" - Exclude: - - "**/*.erb" - - "acceptance/**/*" - - "autotest/**/*" - - "spec/**/*" - - "tasks/**/*" - - "vendor/**/*" +--- +inherit_from: .rubocop_todo.yml -# Turning off some failing checks until it is determined which one is breaking things -Style/AccessorGrouping: - Enabled: false -Style/CaseLikeIf: - Enabled: false -Style/GlobalStdStream: - Enabled: false -Style/RedundantRegexpCharacterClass: - Enabled: false -Style/SoleNestedConditional: - Enabled: false -Style/StringConcatenation: - Enabled: false -# end turning things off for debugging - -Layout/ConditionPosition: - Enabled: true - -Lint/ElseLayout: - Enabled: true - -Lint/UnreachableCode: - Enabled: true - -Lint/BinaryOperatorWithIdenticalOperands: - Enabled: true - -# MAYBE useful - no return inside ensure block. -Lint/EnsureReturn: - Enabled: false - -# MAYBE useful - errors when rescue {} happens. -Lint/SuppressedException: - Enabled: false - -Lint/ShadowingOuterLocalVariable: - Enabled: true - -# Can catch complicated strings. -Lint/LiteralInInterpolation: - Enabled: true - -# DISABLED really useless. Detects return as last statement. -Style/RedundantReturn: - Enabled: false - -# Disabled. Throws an error trying to run. -Style/RedundantParentheses: - Enabled: false - -# DISABLED since the instances do not seem to indicate any specific errors. -Lint/AmbiguousOperator: - Enabled: false - -# DISABLED since for all the checked, we are basically checking nil -# TODO: Change the checking so that if the variable being assigned to has -# a value ALREADY, then raise an error. -Lint/AssignmentInCondition: - Enabled: false - -# DISABLED - not useful -Layout/SpaceBeforeComment: - Enabled: false - -# DISABLED - not useful -Style/HashSyntax: - Enabled: false - -# USES: as shortcut for non nil&valid checking a = x() and a.empty? -# DISABLED - not useful -Style/AndOr: - Enabled: false - -# DISABLED - not useful -Style/RedundantSelf: - Enabled: false - -# DISABLED - not useful -Metrics/MethodLength: - Enabled: false - -Metrics/BlockLength: - Enabled: false - -# DISABLED - not useful -Style/WhileUntilModifier: - Enabled: false - -# DISABLED - the offender is just haskell envy -Lint/AmbiguousRegexpLiteral: - Enabled: false - -# DISABLED -Security/Eval: - Enabled: false - -# DISABLED -Layout/BlockAlignment: - Enabled: false - -# DISABLED -Layout/DefEndAlignment: - Enabled: false - -# DISABLED -Layout/EndAlignment: - Enabled: false - -# DISABLED -Lint/DeprecatedClassMethods: - Enabled: false - -# DISABLED -Lint/Loop: - Enabled: false - -# DISABLED -Lint/ParenthesesAsGroupedExpression: - Enabled: false - -Lint/RescueException: - Enabled: false - -Lint/RedundantStringCoercion: - Enabled: false - -Lint/UnusedBlockArgument: - Enabled: false - -Lint/UnusedMethodArgument: - Enabled: false - -# DISABLED - TODO -Lint/UselessAccessModifier: - Enabled: false - -# DISABLED - TODO -Lint/UselessAssignment: - Enabled: false - -# DISABLED - TODO -Lint/Void: - Enabled: false - -Layout/AccessModifierIndentation: - Enabled: false - -Naming/AccessorMethodName: - Enabled: false - -Style/Alias: - Enabled: false - -Layout/ArrayAlignment: - Enabled: false - -Layout/HashAlignment: - Enabled: false - -Layout/ParameterAlignment: - Enabled: false - -Layout/HeredocIndentation: - Enabled: false - -Metrics/BlockNesting: - Enabled: false - -Style/AsciiComments: - Enabled: false - -Style/Attr: - Enabled: false - -Style/CaseEquality: - Enabled: false - -Style/SymbolArray: - Enabled: false - -Style/EmptyCaseCondition: - Enabled: false - -Layout/CaseIndentation: - Enabled: false - -Layout/MultilineMethodCallBraceLayout: - Enabled: false - -Style/CharacterLiteral: - Enabled: false - -Naming/ClassAndModuleCamelCase: - Enabled: false - -Style/ClassAndModuleChildren: - Enabled: false - -Style/ClassCheck: - Enabled: false - -Metrics/ClassLength: - Enabled: false - -Style/ClassMethods: - Enabled: false - -Style/ClassVars: - Enabled: false - -Style/WhenThen: - Enabled: false - -# DISABLED - not useful -Style/WordArray: - Enabled: false - -Style/RedundantPercentQ: - Enabled: false - -Layout/IndentationStyle: - Enabled: false - -Layout/SpaceBeforeSemicolon: - Enabled: false - -Layout/TrailingEmptyLines: - Enabled: false - -Layout/SpaceInsideBlockBraces: - Enabled: false - -Layout/SpaceInsideHashLiteralBraces: - Enabled: false - -Layout/SpaceInsideParens: - Enabled: false - -Layout/LeadingCommentSpace: - Enabled: false - -Layout/SpaceAfterColon: - Enabled: false - -Layout/SpaceAfterComma: - Enabled: false - -Layout/SpaceAroundKeyword: - Enabled: false - -Layout/SpaceAfterMethodName: - Enabled: false - -Layout/SpaceAfterNot: - Enabled: false - -Layout/SpaceAfterSemicolon: - Enabled: false - -Layout/SpaceAroundEqualsInParameterDefault: - Enabled: false - -Layout/SpaceAroundOperators: - Enabled: false - -Layout/SpaceBeforeBlockBraces: - Enabled: false - -Layout/SpaceBeforeComma: - Enabled: false - -Style/CollectionMethods: - Enabled: false - -Layout/CommentIndentation: - Enabled: false - -Style/ColonMethodCall: - Enabled: false - -Style/CommentAnnotation: - Enabled: false - -Metrics/CyclomaticComplexity: - Enabled: false - -Naming/ConstantName: - Enabled: false - -Style/Documentation: - Enabled: false - -Style/DefWithParentheses: - Enabled: false - -Style/PreferredHashMethods: - Enabled: false - -Layout/DotPosition: - Enabled: false - -# DISABLED - used for converting to bool -Style/DoubleNegation: - Enabled: false - -Style/EachWithObject: - Enabled: false - -Layout/EmptyLineBetweenDefs: - Enabled: false - -Layout/FirstArrayElementIndentation: - Enabled: false - -Layout/FirstHashElementIndentation: - Enabled: false - -Layout/IndentationConsistency: - Enabled: false - -Layout/IndentationWidth: - Enabled: false - -Layout/EmptyLines: - Enabled: false - -Layout/EmptyLinesAroundAccessModifier: - Enabled: false - -Style/EmptyLiteral: - Enabled: false - -Layout/LineLength: - Enabled: false - -Style/MethodCallWithoutArgsParentheses: - Enabled: false - -Style/MethodDefParentheses: - Enabled: false - -Style/LineEndConcatenation: - Enabled: false - -Layout/TrailingWhitespace: - Enabled: false - -Style/StringLiterals: - Enabled: false - -Style/TrailingCommaInArrayLiteral: - Enabled: false - -Style/TrailingCommaInHashLiteral: - Enabled: false - -Style/TrailingCommaInArguments: - Enabled: false - -Style/GlobalVars: - Enabled: false - -Style/GuardClause: - Enabled: false - -Style/IfUnlessModifier: - Enabled: false - -Style/MultilineIfThen: - Enabled: false - -Style/NegatedIf: - Enabled: false - -Style/NegatedWhile: - Enabled: false - -Style/Next: - Enabled: false - -Style/SingleLineBlockParams: - Enabled: false - -Style/SingleLineMethods: - Enabled: false - -Style/SpecialGlobalVars: - Enabled: false - -Style/TrivialAccessors: - Enabled: false - -Style/UnlessElse: - Enabled: false - -Style/VariableInterpolation: - Enabled: false - -Naming/VariableName: - Enabled: false - -Style/WhileUntilDo: - Enabled: false - -Style/EvenOdd: - Enabled: false - -Naming/FileName: - Enabled: false - -Style/For: - Enabled: false - -Style/Lambda: - Enabled: false - -Naming/MethodName: - Enabled: false - -Style/MultilineTernaryOperator: - Enabled: false - -Style/NestedTernaryOperator: - Enabled: false - -Style/NilComparison: - Enabled: false - -Style/FormatString: - Enabled: false - -Style/MultilineBlockChain: - Enabled: false - -Style/Semicolon: - Enabled: false - -Style/SignalException: - Enabled: false - -Style/NonNilCheck: - Enabled: false - -Style/Not: - Enabled: false - -Style/NumericLiterals: - Enabled: false - -Style/OneLineConditional: - Enabled: false - -Naming/BinaryOperatorParameterName: - Enabled: false - -Style/ParenthesesAroundCondition: - Enabled: false - -Style/PercentLiteralDelimiters: - Enabled: false - -Style/PerlBackrefs: - Enabled: false - -Naming/PredicateName: - Enabled: false - -Style/RedundantException: - Enabled: false - -Style/SelfAssignment: - Enabled: false - -Style/Proc: - Enabled: false - -Style/RaiseArgs: - Enabled: false - -Style/RedundantBegin: - Enabled: false - -Style/RescueModifier: - Enabled: false - -Style/RegexpLiteral: - Enabled: false - -Lint/UnderscorePrefixedVariableName: - Enabled: false - -Metrics/ParameterLists: - Enabled: false - -Lint/RequireParentheses: - Enabled: false - -Layout/SpaceBeforeFirstArg: - Enabled: false - -Style/ModuleFunction: - Enabled: false - -Lint/Debugger: - Enabled: false - -Style/IfWithSemicolon: - Enabled: false - -Style/Encoding: - Enabled: false - -Metrics/PerceivedComplexity: - Enabled: false - -Style/SymbolProc: - Enabled: false - -Layout/SpaceInsideRangeLiteral: - Enabled: false - -Style/InfiniteLoop: - Enabled: false - -Style/BarePercentLiterals: - Enabled: false - -Style/PercentQLiterals: - Enabled: false - -Layout/MultilineBlockLayout: - Enabled: false - -Metrics/AbcSize: - Enabled: false - -Style/MutableConstant: - Enabled: false - -Style/BlockDelimiters: - Enabled: false - -Layout/EmptyLinesAroundClassBody: - Enabled: false - -Style/ConditionalAssignment: - Enabled: false - -Layout/ExtraSpacing: - Enabled: false - -Layout/EmptyLinesAroundBlockBody: - Enabled: false - -Layout/EmptyLinesAroundModuleBody: - Enabled: false - -Layout/MultilineOperationIndentation: - Enabled: false - -Style/EmptyElse: - Enabled: false - -Style/StringLiteralsInInterpolation: - Enabled: false - -Layout/MultilineMethodCallIndentation: - Enabled: false - -Metrics/ModuleLength: - Enabled: false - -Layout/EmptyLinesAroundMethodBody: - Enabled: false - -Lint/IneffectiveAccessModifier: - Enabled: false - -Layout/ClosingParenthesisIndentation: - Enabled: false - -Style/RedundantInterpolation: - Enabled: false - -Layout/ElseAlignment: - Enabled: false - -Style/FrozenStringLiteralComment: - Enabled: false - -Layout/FirstParameterIndentation: - Enabled: false - -Style/IfInsideElse: - Enabled: false - -Layout/AssignmentIndentation: - Enabled: false - -Layout/SpaceAroundBlockParameters: - Enabled: false - -Style/ParallelAssignment: - Enabled: false - -Style/IdenticalConditionalBranches: - Enabled: false - -Style/CommandLiteral: - Enabled: false - -Lint/NestedMethodDefinition: - Enabled: false - -Layout/SpaceInsideStringInterpolation: - Enabled: false - -Style/NestedModifier: - Enabled: false - -Lint/NonLocalExitFromIterator: - Enabled: false - -Style/NestedParenthesizedCalls: - Enabled: false - -Layout/RescueEnsureAlignment: - Enabled: false - -Lint/DuplicateMethods: - Enabled: false - -Style/TrailingUnderscoreVariable: - Enabled: false - -Style/RedundantSortBy: - Enabled: false - -Layout/InitialIndentation: - Enabled: false - -Style/StructInheritance: - Enabled: false - -Style/SymbolLiteral: - Enabled: false - -Style/IfUnlessModifierOfIfUnless: - Enabled: false - -Style/ZeroLengthPredicate: - Enabled: false - -Bundler/OrderedGems: - Enabled: false - -# Enforce LF line endings, even when on Windows -Layout/EndOfLine: - EnforcedStyle: lf - -Layout/SpaceAroundMethodCallOperator: - Enabled: true - -Lint/RaiseException: - Enabled: true - -Lint/StructNewOverride: - Enabled: true - -Style/ExponentialNotation: - Enabled: true - -Style/HashEachMethods: - Enabled: true - -Style/HashTransformKeys: - Enabled: true - -Style/HashTransformValues: - Enabled: true - -# Not used becuase too new for support matrix -Style/NumericPredicate: - Enabled: false - -# Not used becuase too new for support matrix -Style/SafeNavigation: - Enabled: false - -Style/MixinUsage: - Enabled: false +inherit_gem: + voxpupuli-rubocop: rubocop.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml new file mode 100644 index 0000000..919de1f --- /dev/null +++ b/.rubocop_todo.yml @@ -0,0 +1,951 @@ +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2024-11-14 21:32:23 UTC using RuboCop version 1.67.0. +# The point is for the user to remove these configuration records +# one by one as the offenses are removed from the code base. +# Note that changes in the inspected code, or installation of new +# versions of RuboCop, may require this file to be generated again. + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include. +# Include: **/*.gemfile, **/Gemfile, **/gems.rb +Bundler/OrderedGems: + Exclude: + - 'Gemfile' + +# Offense count: 17 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Include. +# Include: **/*.gemspec +Gemspec/AddRuntimeDependency: + Exclude: + - 'onceover.gemspec' + +# Offense count: 1 +# Configuration parameters: Severity, Include. +# Include: **/*.gemspec +Gemspec/RequiredRubyVersion: + Exclude: + - 'onceover.gemspec' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyleAlignWith. +# SupportedStylesAlignWith: either, start_of_block, start_of_line +Layout/BlockAlignment: + Exclude: + - 'lib/onceover/controlrepo.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth. +# SupportedStyles: case, end +Layout/CaseIndentation: + Exclude: + - 'lib/onceover/beaker.rb' + +# Offense count: 5 +# This cop supports safe autocorrection (--autocorrect). +Layout/ElseAlignment: + Exclude: + - 'lib/onceover/controlrepo.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, DefLikeMacros, AllowAdjacentOneLineDefs, NumberOfEmptyLines. +Layout/EmptyLineBetweenDefs: + Exclude: + - 'lib/onceover/controlrepo.rb' + +# Offense count: 8 +# This cop supports safe autocorrection (--autocorrect). +Layout/EmptyLines: + Exclude: + - 'Rakefile' + - 'lib/onceover/beaker.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/node.rb' + - 'lib/onceover/rake_tasks.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: empty_lines, no_empty_lines +Layout/EmptyLinesAroundBlockBody: + Exclude: + - 'lib/onceover/rake_tasks.rb' + +# Offense count: 6 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only +Layout/EmptyLinesAroundClassBody: + Exclude: + - 'features/support/cache_helper.rb' + - 'features/support/command_helper.rb' + - 'features/support/controlrepo_helper.rb' + - 'lib/onceover/rspec/formatters.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Layout/EmptyLinesAroundMethodBody: + Exclude: + - 'lib/onceover/node.rb' + - 'lib/onceover/test.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyleAlignWith, Severity. +# SupportedStylesAlignWith: keyword, variable, start_of_line +Layout/EndAlignment: + Exclude: + - 'lib/onceover/controlrepo.rb' + +# Offense count: 8 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment. +Layout/ExtraSpacing: + Exclude: + - 'features/step_definitions/common.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/rake_tasks.rb' + +# Offense count: 5 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, IndentationWidth. +# SupportedStyles: special_inside_parentheses, consistent, align_braces +Layout/FirstHashElementIndentation: + Exclude: + - 'features/support/cache_helper.rb' + - 'lib/onceover/beaker.rb' + - 'lib/onceover/controlrepo.rb' + +# Offense count: 24 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle. +# SupportedHashRocketStyles: key, separator, table +# SupportedColonStyles: key, separator, table +# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit +Layout/HashAlignment: + Exclude: + - 'lib/onceover/beaker/spec_helper.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/logger.rb' + - 'lib/onceover/rspec/formatters.rb' + - 'lib/onceover/test.rb' + - 'lib/onceover/testconfig.rb' + - 'spec/onceover/controlrepo_spec.rb' + +# Offense count: 6 +# This cop supports safe autocorrection (--autocorrect). +Layout/HeredocIndentation: + Exclude: + - 'lib/onceover/cli/init.rb' + - 'lib/onceover/cli/run.rb' + - 'lib/onceover/cli/show.rb' + - 'lib/onceover/cli/update.rb' + +# Offense count: 7 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Width, AllowedPatterns. +Layout/IndentationWidth: + Exclude: + - 'lib/onceover/controlrepo.rb' + +# Offense count: 12 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment, AllowRBSInlineAnnotation. +Layout/LeadingCommentSpace: + Exclude: + - 'lib/onceover/beaker/spec_helper.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/runner.rb' + - 'onceover.gemspec' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: symmetrical, new_line, same_line +Layout/MultilineMethodCallBraceLayout: + Exclude: + - 'lib/onceover/testconfig.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Layout/SpaceAfterColon: + Exclude: + - 'spec/onceover/controlrepo_spec.rb' + +# Offense count: 43 +# This cop supports safe autocorrection (--autocorrect). +Layout/SpaceAfterComma: + Exclude: + - 'features/step_definitions/cache.rb' + - 'features/support/cache_helper.rb' + - 'lib/onceover/beaker.rb' + - 'lib/onceover/beaker/spec_helper.rb' + - 'lib/onceover/cli/run.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/deploy.rb' + - 'lib/onceover/rspec/formatters.rb' + - 'lib/onceover/test.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Layout/SpaceAfterNot: + Exclude: + - 'lib/onceover/testconfig.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyleInsidePipes. +# SupportedStylesInsidePipes: space, no_space +Layout/SpaceAroundBlockParameters: + Exclude: + - 'lib/onceover/testconfig.rb' + +# Offense count: 6 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator, EnforcedStyleForRationalLiterals. +# SupportedStylesForExponentOperator: space, no_space +# SupportedStylesForRationalLiterals: space, no_space +Layout/SpaceAroundOperators: + Exclude: + - 'features/step_definitions/common.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/test.rb' + +# Offense count: 8 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. +# SupportedStyles: space, no_space +# SupportedStylesForEmptyBraces: space, no_space +Layout/SpaceBeforeBlockBraces: + Exclude: + - 'lib/onceover/cli/plugins.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Layout/SpaceBeforeComment: + Exclude: + - 'lib/onceover/controlrepo.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets. +# SupportedStyles: space, no_space, compact +# SupportedStylesForEmptyBrackets: space, no_space +Layout/SpaceInsideArrayLiteralBrackets: + Exclude: + - 'features/step_definitions/init.rb' + +# Offense count: 33 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. +# SupportedStyles: space, no_space +# SupportedStylesForEmptyBraces: space, no_space +Layout/SpaceInsideBlockBraces: + Exclude: + - 'Rakefile' + - 'features/step_definitions/init.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/node.rb' + - 'lib/onceover/rspec/formatters.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 14 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. +# SupportedStyles: space, no_space, compact +# SupportedStylesForEmptyBraces: space, no_space +Layout/SpaceInsideHashLiteralBraces: + Exclude: + - 'lib/onceover/beaker.rb' + - 'lib/onceover/test.rb' + +# Offense count: 13 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: space, compact, no_space +Layout/SpaceInsideParens: + Exclude: + - 'features/step_definitions/common.rb' + - 'features/step_definitions/init.rb' + - 'features/support/controlrepo_helper.rb' + - 'lib/onceover/controlrepo.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: final_newline, final_blank_line +Layout/TrailingEmptyLines: + Exclude: + - 'features/step_definitions/formatter.rb' + - 'features/support/env.rb' + +# Offense count: 9 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowInHeredoc. +Layout/TrailingWhitespace: + Exclude: + - 'features/step_definitions/common.rb' + - 'features/step_definitions/formatter.rb' + - 'lib/onceover/deploy.rb' + - 'lib/onceover/node.rb' + - 'lib/onceover/rspec/formatters.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 3 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowSafeAssignment. +Lint/AssignmentInCondition: + Exclude: + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/node.rb' + +# Offense count: 4 +# This cop supports safe autocorrection (--autocorrect). +Lint/ErbNewArguments: + Exclude: + - 'lib/onceover/rake_tasks.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Lint/RedundantCopDisableDirective: + Exclude: + - 'onceover.gemspec' + +# Offense count: 10 +# This cop supports safe autocorrection (--autocorrect). +Lint/RedundantStringCoercion: + Exclude: + - 'lib/onceover/cli/show.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/rake_tasks.rb' + - 'lib/onceover/rspec/formatters.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 1 +Lint/RescueException: + Exclude: + - 'bin/onceover' + +# Offense count: 4 +# Configuration parameters: AllowKeywordBlockArguments. +Lint/UnderscorePrefixedVariableName: + Exclude: + - 'lib/onceover/controlrepo.rb' + +# Offense count: 20 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AutoCorrect, IgnoreEmptyBlocks, AllowUnusedKeywordArguments. +Lint/UnusedBlockArgument: + Exclude: + - 'lib/onceover/cli.rb' + - 'lib/onceover/cli/init.rb' + - 'lib/onceover/cli/plugins.rb' + - 'lib/onceover/cli/run.rb' + - 'lib/onceover/cli/show.rb' + - 'lib/onceover/cli/update.rb' + - 'lib/onceover/rspec/formatters.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 8 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AutoCorrect, AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. +Lint/UnusedMethodArgument: + Exclude: + - 'lib/onceover/beaker.rb' + - 'lib/onceover/rspec/formatters.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AutoCorrect. +Lint/UselessAssignment: + Exclude: + - 'lib/onceover/rspec/formatters.rb' + - 'lib/onceover/runner.rb' + +# Offense count: 3 +# Configuration parameters: AllowedNames. +# AllowedNames: module_parent +Naming/ClassAndModuleCamelCase: + Exclude: + - 'features/support/cache_helper.rb' + - 'features/support/command_helper.rb' + - 'features/support/controlrepo_helper.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Performance/RedundantBlockCall: + Exclude: + - 'lib/onceover/controlrepo.rb' + +# Offense count: 3 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowRegexpMatch. +Performance/RedundantEqualityComparisonBlock: + Exclude: + - 'lib/onceover/group.rb' + - 'lib/onceover/test.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Performance/RedundantMatch: + Exclude: + - 'lib/onceover/deploy.rb' + +# Offense count: 6 +# This cop supports safe autocorrection (--autocorrect). +Performance/RegexpMatch: + Exclude: + - 'Rakefile' + - 'features/step_definitions/run.rb' + - 'lib/onceover/beaker.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/deploy.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Performance/ReverseEach: + Exclude: + - 'lib/onceover/deploy.rb' + +# Offense count: 3 +# This cop supports unsafe autocorrection (--autocorrect-all). +Performance/StringInclude: + Exclude: + - 'lib/onceover/beaker.rb' + - 'lib/onceover/deploy.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +Performance/StringReplacement: + Exclude: + - 'lib/onceover/cli/plugins.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 1 +# Configuration parameters: Prefixes, AllowedPatterns. +# Prefixes: when, with, without +RSpec/ContextWording: + Exclude: + - 'spec/onceover/controlrepo_spec.rb' + +# Offense count: 1 +# Configuration parameters: AssignmentOnly. +RSpec/InstanceVariable: + Exclude: + - 'spec/onceover/controlrepo_spec.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Rake/Desc: + Exclude: + - 'Rakefile' + +# Offense count: 2 +Security/Eval: + Exclude: + - 'Gemfile' + +# Offense count: 2 +# This cop supports unsafe autocorrection (--autocorrect-all). +Security/IoMethods: + Exclude: + - 'features/step_definitions/common.rb' + +# Offense count: 1 +Security/Open: + Exclude: + - 'features/support/controlrepo_helper.rb' + +# Offense count: 44 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: separated, grouped +Style/AccessorGrouping: + Exclude: + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/node.rb' + - 'lib/onceover/runner.rb' + - 'lib/onceover/test.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 3 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: always, conditionals +Style/AndOr: + Exclude: + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/deploy.rb' + +# Offense count: 5 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: percent_q, bare_percent +Style/BarePercentLiterals: + Exclude: + - 'features/step_definitions/common.rb' + - 'features/step_definitions/init.rb' + - 'features/step_definitions/run.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods. +# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces +# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object +# FunctionalMethods: let, let!, subject, watch +# AllowedMethods: lambda, proc, it +Style/BlockDelimiters: + Exclude: + - 'lib/onceover/node.rb' + - 'lib/onceover/rspec/formatters.rb' + +# Offense count: 2 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: MinBranchesCount. +Style/CaseLikeIf: + Exclude: + - 'lib/onceover/test.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: nested, compact +Style/ClassAndModuleChildren: + Exclude: + - 'lib/onceover/logger.rb' + +# Offense count: 6 +Style/ClassVars: + Exclude: + - 'lib/onceover/class.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/group.rb' + - 'lib/onceover/node.rb' + - 'lib/onceover/test.rb' + +# Offense count: 9 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions. +# SupportedStyles: assign_to_condition, assign_inside_condition +Style/ConditionalAssignment: + Exclude: + - 'features/support/cache_helper.rb' + - 'lib/onceover/beaker.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/test.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 26 +# Configuration parameters: AllowedConstants. +Style/Documentation: + Enabled: false + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: allowed_in_returns, forbidden +Style/DoubleNegation: + Exclude: + - 'lib/onceover/testconfig.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +Style/EmptyCaseCondition: + Exclude: + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/group.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AutoCorrect, EnforcedStyle, AllowComments. +# SupportedStyles: empty, nil, both +Style/EmptyElse: + Exclude: + - 'lib/onceover/controlrepo.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/Encoding: + Exclude: + - 'onceover.gemspec' + +# Offense count: 33 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: always, always_true, never +Style/FrozenStringLiteralComment: + Enabled: false + +# Offense count: 6 +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/GlobalStdStream: + Exclude: + - 'features/step_definitions/formatter.rb' + - 'lib/onceover/runner.rb' + +# Offense count: 6 +# Configuration parameters: AllowedVariables. +Style/GlobalVars: + Exclude: + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/logger.rb' + +# Offense count: 5 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals. +Style/GuardClause: + Exclude: + - 'lib/onceover/class.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/deploy.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowSplatArgument. +Style/HashConversion: + Exclude: + - 'features/support/cache_helper.rb' + +# Offense count: 40 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. +# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys +# SupportedShorthandSyntax: always, never, either, consistent, either_consistent +Style/HashSyntax: + Exclude: + - 'lib/onceover/beaker.rb' + - 'lib/onceover/beaker/spec_helper.rb' + - 'lib/onceover/cli.rb' + - 'lib/onceover/cli/run.rb' + - 'lib/onceover/cli/show.rb' + - 'lib/onceover/cli/update.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/logger.rb' + +# Offense count: 4 +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/IdenticalConditionalBranches: + Exclude: + - 'lib/onceover/testconfig.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowIfModifier. +Style/IfInsideElse: + Exclude: + - 'lib/onceover/controlrepo.rb' + +# Offense count: 19 +# This cop supports safe autocorrection (--autocorrect). +Style/IfUnlessModifier: + Exclude: + - 'Gemfile' + - 'features/step_definitions/common.rb' + - 'lib/onceover/beaker.rb' + - 'lib/onceover/class.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/group.rb' + - 'lib/onceover/rake_tasks.rb' + - 'lib/onceover/runner.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 12 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline +Style/MethodDefParentheses: + Exclude: + - 'lib/onceover/rspec/formatters.rb' + +# Offense count: 3 +Style/MixinUsage: + Exclude: + - 'lib/onceover/beaker/spec_helper.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 3 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: literals, strict +Style/MutableConstant: + Exclude: + - 'lib/onceover/rspec/formatters.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowedMethods. +# AllowedMethods: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with +Style/NestedParenthesizedCalls: + Exclude: + - 'features/step_definitions/init.rb' + +# Offense count: 4 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, MinBodyLength. +# SupportedStyles: skip_modifier_ifs, always +Style/Next: + Exclude: + - 'lib/onceover/deploy.rb' + - 'lib/onceover/rake_tasks.rb' + - 'lib/onceover/runner.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 6 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: predicate, comparison +Style/NilComparison: + Exclude: + - 'lib/onceover/deploy.rb' + - 'lib/onceover/runner.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/Not: + Exclude: + - 'lib/onceover/deploy.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns. +# SupportedStyles: predicate, comparison +Style/NumericPredicate: + Exclude: + - 'spec/**/*' + - 'lib/onceover/deploy.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: lower_case_q, upper_case_q +Style/PercentQLiterals: + Exclude: + - 'features/step_definitions/common.rb' + - 'features/step_definitions/init.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/PerlBackrefs: + Exclude: + - 'lib/onceover/controlrepo.rb' + +# Offense count: 8 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: short, verbose +Style/PreferredHashMethods: + Exclude: + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/rake_tasks.rb' + - 'lib/onceover/runner.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 4 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantBegin: + Exclude: + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/group.rb' + - 'lib/onceover/runner.rb' + +# Offense count: 4 +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/RedundantInterpolation: + Exclude: + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/rspec/formatters.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantParentheses: + Exclude: + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/deploy.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantPercentQ: + Exclude: + - 'features/step_definitions/common.rb' + - 'features/step_definitions/init.rb' + - 'features/step_definitions/run.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantRegexpEscape: + Exclude: + - 'features/step_definitions/common.rb' + +# Offense count: 12 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowMultipleReturnValues. +Style/RedundantReturn: + Exclude: + - 'features/support/command_helper.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/group.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 4 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantSelf: + Exclude: + - 'lib/onceover/beaker.rb' + - 'lib/onceover/controlrepo.rb' + +# Offense count: 6 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, AllowInnerSlashes. +# SupportedStyles: slashes, percent_r, mixed +Style/RegexpLiteral: + Exclude: + - 'features/step_definitions/run.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/rspec/formatters.rb' + - 'lib/onceover/testconfig.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength. +# AllowedMethods: present?, blank?, presence, try, try! +Style/SafeNavigation: + Exclude: + - 'lib/onceover/testconfig.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/SelfAssignment: + Exclude: + - 'features/support/cache_helper.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowAsExpressionSeparator. +Style/Semicolon: + Exclude: + - 'lib/onceover/beaker.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: only_raise, only_fail, semantic +Style/SignalException: + Exclude: + - 'lib/onceover/controlrepo.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/SlicingWithRange: + Exclude: + - 'features/step_definitions/common.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowModifier. +Style/SoleNestedConditional: + Exclude: + - 'lib/onceover/rake_tasks.rb' + - 'lib/onceover/runner.rb' + +# Offense count: 2 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: RequireEnglish, EnforcedStyle. +# SupportedStyles: use_perl_names, use_english_names, use_builtin_english_names +Style/SpecialGlobalVars: + Exclude: + - 'Rakefile' + - 'lib/onceover/deploy.rb' + +# Offense count: 9 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Mode. +Style/StringConcatenation: + Exclude: + - 'features/support/cache_helper.rb' + - 'features/support/controlrepo_helper.rb' + - 'lib/onceover/rspec/formatters.rb' + - 'lib/onceover/runner.rb' + +# Offense count: 98 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. +# SupportedStyles: single_quotes, double_quotes +Style/StringLiterals: + Enabled: false + +# Offense count: 5 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: MinSize. +# SupportedStyles: percent, brackets +Style/SymbolArray: + EnforcedStyle: brackets + +# Offense count: 5 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments. +# AllowedMethods: define_method +Style/SymbolProc: + Exclude: + - 'lib/onceover/cli/plugins.rb' + - 'lib/onceover/testconfig.rb' + - 'spec/spec_helper.rb' + +# Offense count: 4 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, AllowSafeAssignment. +# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex +Style/TernaryParentheses: + Exclude: + - 'lib/onceover/beaker/spec_helper.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/deploy.rb' + +# Offense count: 13 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyleForMultiline. +# SupportedStylesForMultiline: comma, consistent_comma, no_comma +Style/TrailingCommaInArguments: + Exclude: + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/logger.rb' + - 'lib/onceover/runner.rb' + - 'lib/onceover/testconfig.rb' + - 'spec/onceover/controlrepo_spec.rb' + +# Offense count: 10 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyleForMultiline. +# SupportedStylesForMultiline: comma, consistent_comma, no_comma +Style/TrailingCommaInHashLiteral: + Exclude: + - 'features/support/cache_helper.rb' + - 'lib/onceover/controlrepo.rb' + - 'lib/onceover/logger.rb' + - 'lib/onceover/test.rb' + - 'lib/onceover/testconfig.rb' + - 'spec/onceover/controlrepo_spec.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/WhileUntilDo: + Exclude: + - 'lib/onceover/controlrepo.rb' + +# Offense count: 24 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 421 diff --git a/Rakefile b/Rakefile index d40365b..ba38407 100644 --- a/Rakefile +++ b/Rakefile @@ -1,7 +1,6 @@ require 'rubygems/tasks' require 'rspec/core/rake_task' require 'cucumber/rake/task' -require 'rubocop/rake_task' require 'puppet/version' Gem::Tasks.new @@ -38,10 +37,10 @@ task default: :full_tests desc "Run unit tests" -task rspec_unit_tests: [:syntax, :rubocop, :spec] +task rspec_unit_tests: [:syntax, :spec] desc "Run acceptance cucumber tests" -task cucumber_acceptance_tests: [:syntax, :rubocop, :fixtures, :cucumber] +task cucumber_acceptance_tests: [:syntax, :fixtures, :cucumber] desc "Run full set of tests" task full_tests: [:rspec_unit_tests, :cucumber_acceptance_tests] @@ -60,16 +59,13 @@ task :syntax do end end -RuboCop::RakeTask.new(:rubocop) do |task| - task.options << '--display-cop-names' - task.formatters = ['simple'] - task.patterns = [ - "lib/**/*.rb", - "ext/**/*.rb", - ] -end - task :fixtures do system 'git submodule init && git submodule update --recursive' raise "Couldn't clone controlrepo to fixtures directory" unless $?.success? end + +begin + require 'voxpupuli/rubocop/rake' +rescue LoadError + # the voxpupuli-rubocop gem is optional +end diff --git a/onceover.gemspec b/onceover.gemspec index 1e4315a..36193ee 100644 --- a/onceover.gemspec +++ b/onceover.gemspec @@ -37,4 +37,5 @@ Gem::Specification.new do |s| # rubocop:disable Gemspec/RequireMFA s.add_runtime_dependency 'rspec-puppet', ">= 2.4.0" s.add_runtime_dependency 'terminal-table', '>= 1.8.0' s.add_runtime_dependency 'versionomy', '>= 0.5.0' + s.add_development_dependency 'voxpupuli-rubocop', '~> 3.0.0' end