Skip to content

Koth ladder - #596

Merged
plind-junior merged 5 commits into
testfrom
koth-ladder
Jul 29, 2026
Merged

Koth ladder#596
plind-junior merged 5 commits into
testfrom
koth-ladder

Conversation

@plind-junior

Copy link
Copy Markdown
Member

What changed

Why

What might break

VEP

Tests

  • make check passes locally (lint + mypy + pytest)
  • New / changed behaviour has a test
  • CHANGELOG.md updated under ## [Unreleased]

a winning strategy submission now auto-merges on the ladder branch -
the benchmark decides what enters contrib/, with no human in the loop.
the arm job is deliberately separate from the scoring job: scoring
executes the untrusted challenger and keeps a read-only token; arming
holds the write scopes, checks out nothing, and runs no challenger
code. auto-merge fires only when the pr base is KOTH_LADDER_BASE,
exactly like the kit lane.

what keeps this sane is the quarantine, now stated as the contract in
the workflow header and the strategy module docstring: merged contrib
strategies execute exclusively through the sandbox child (both gates
and the local bench wrap them in SandboxProxy), the ledger and ratchet
scripts treat the winner as text and import nothing, and promotion
into src/vouch as trusted importable default code remains a
human-reviewed pr. accepted residual, documented: a sandbox escape
during scoring can forge its own verdict and land its pr - inside the
quarantine it already runs in, with no write token, secrets, or
import path reachable.

docs and the scorecard comment updated to stop claiming engine code
never auto-merges.
the engine-lane branch inherits koth-ladder's copy of
test_handler_returns_degraded_when_absent, which calls handle_request
against whatever .vouch/ the cwd happens to sit under. that passes on a
developer checkout and fails in ci — where .vouch/ is gitignored — with
an internal_error out of _store(), so every pr targeting koth-ladder
goes red on a failure it did not cause.

chdir into the fixture kb and empty both transcript search roots so the
absence the test asserts is the raw transcript's, not the kb's. same fix
already on test as c89ca20; this carries it to the koth-ladder lane.
feat(competition): engine-lane auto-merge on dethrone, quarantined
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@plind-junior, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 32 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 331b813c-b047-431e-bd0d-17b8c0ae39b6

📥 Commits

Reviewing files that changed from the base of the PR and between 2722d4f and 899516a.

📒 Files selected for processing (5)
  • .github/scripts/score_strategy.py
  • .github/workflows/koth-engine-gate.yml
  • docs/koth-strategy-lane.md
  • src/vouch/strategy.py
  • tests/test_session_transcript.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added docs documentation, specs, examples, and repo guidance ci github actions and automation tests tests and fixtures size: S 50-199 changed non-doc lines labels Jul 29, 2026
@plind-junior
plind-junior merged commit b4040fc into test Jul 29, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci github actions and automation docs documentation, specs, examples, and repo guidance size: S 50-199 changed non-doc lines tests tests and fixtures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant