Repository navigation
Show X, Slack, and the star count in the docs' and Explorer's header, and move the theme switch to the footer - #11251
Open
lwwmanning wants to merge 5 commits into
Open
lwwmanning wants to merge 5 commits into
lwwmanning wants to merge 5 commits into
Conversation
On a wide screen the header now takes the same 1440px column as on vortex.dev and bench, with its line rule, instead of the full window. The theme bootstrap also copies a choice found only in storage into the shared cookie, so a choice saved before the cookie existed reaches every surface. The Explorer's old 'vortex-theme' key moves through the bootstrap's legacy option. Signed-off-by: Will Manning <will@willmanning.io>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…r's header Slack leaves the shared header's text links. Its mark and X's are icon links before the GitHub button, in the nav links' muted ink, and rows in the Menu on a phone. The GitHub button drops the repository's name, which moves to its title. The marks are their owners' (REUSE.toml). Copies design system v128. Signed-off-by: Will Manning <will@willmanning.io>
The docs (vortex_theme.py) and the Explorer (vite.config.ts) read the repository's star count when they build, as vortex.dev does, so the GitHub button is the same on every surface. The reads send GITHUB_TOKEN when the build has one. Without an answer the button shows the mark alone. Signed-off-by: Will Manning <will@willmanning.io>
robert3005
approved these changes
Nov 5, 2026
…elow 1180px At 800px the header row was crowded once X and Slack sat beside the GitHub button. Below 1180px the GitHub button shows the mark alone, and the count stays in its accessible name. Below 960px X and Slack go into the Menu with the links. Below 640px the theme switch and GitHub follow, as before. The Menu also showed the spill rows (GitHub, and now Slack and X) between 641px and 960px, beside the same buttons on the row: the panel link rule outranked the hide. The hide now names the panel. Signed-off-by: Will Manning <will@willmanning.io>
…below 960px The theme switch moves from the header to the footer, after the links. On a phone it moves up to the line of the Linux Foundation mark, and below 360px the mark is 10px tall so that both fit at 320px. The Menu has no Theme row. Below 960px the header row is the wordmark, the tools, the GitHub mark, and the Menu. The GitHub button drops its star count, which stays in its name. The GitHub and Menu buttons are 32px squares with an icon only. X and Slack go into the Menu from 960px, not 1180px. On the Explorer the footer, and so the switch, shows on the start page only. Signed-off-by: Will Manning <will@willmanning.io>
lwwmanning
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the shared header and footer on the docs and the Explorer, to match vortex.dev and bench. It copies design system v128.
GITHUB_TOKENwhen the build has one. Below 1180px, the button hides the count.The theme bootstrap now moves the Explorer's old
vortex-themestorage key through the system'slegacyoption. vortex-data/vortex.dev#195 makes the same header change on the site.Light theme
The page-width cap, at 2560px:
🤖 Generated with Claude Code