Repository navigation
Show the same header, footer, 404, and theme switch on the docs and Explorer - #11249
Merged
Merged
Conversation
Function names in code take the gold syntax-function colour, and the copy drops rules the Explorer does not draw (FilterChip, FileMap, DetailStrip, vx-page, vx-band, vx-split, vx-lede, vx-stat). Signed-off-by: Will Manning <will@willmanning.io>
The docs now draw the header every Vortex surface shares: the wordmark, the links to Docs, Bench, Explorer, Blog, and Slack, the search, the theme switch, and GitHub. The footer is the shared one, with the LF logo. A theme chosen on any vortex.dev surface holds here too. An address that matches no page gets the shared 404 page, with a 404 status. Titles read "<Page> | Vortex". The CSP now allows the docs' own font, which it blocked before. Signed-off-by: Will Manning <will@willmanning.io>
The Explorer now draws the header every Vortex surface shares: the wordmark back to vortex.dev, the links, the theme switch, the GitHub button, and the Menu. The open file, the view switch, and Close are its tools, with twins in the Menu on a phone. The start page has the shared footer. A second page, 404.html, is the shared 404, served with a 404 status for any address but /. The theme follows the vx-theme cookie that the other surfaces set, and defaults to System. Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
The docs' project now deploys the Explorer too. Vite builds it under /explorer/, web-build.yml uploads it as an explorer/ directory, and the docs and docs preview workflows merge it into the docs build before the upload. docs/vercel-output-config.json gives /explorer/ the Explorer's CSP, serves explorer/ at the root of explore.vortex.dev with its own 404, and sends docs.vortex.dev/explorer to explore.vortex.dev. A preview serves the Explorer at /explorer/. pages-html-routes.py now gives a directory with its own 404.html that page for its missing addresses. web.yml keeps the Explorer's checks and no longer deploys to the Explorer's own project. Signed-off-by: Will Manning <will@willmanning.io>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
synchronized with vortex-data/vortex.dev#194 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11d90b6aaa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The 404 is served at whatever address missed, so the build makes its relative URLs root-relative. It rewrote links and assets but not the header's search form, which then searched under the missed address. Signed-off-by: Will Manning <will@willmanning.io>
The docs build the monorepo's one 404, and the deploy serves it for every missing address, on docs.vortex.dev and on explore.vortex.dev. The Explorer's own 404 is gone. The page now matches vortex.dev's: the turning ASCII mark over the dot field, the same three buttons, and no nav item marked current. The mark loads once the page is idle, from a copy of three@0.170.0 (the site's version), because the docs' CSP allows scripts from their own origin only. On explore.vortex.dev, /_static/ passes through, so the 404's assets load. The 404's links to the docs and its search are absolute, and the CSPs allow its search to post to docs.vortex.dev. Signed-off-by: Will Manning <will@willmanning.io>
The shared vx-theme cookie still wins, then this origin's storage. Without either, the theme is Dark, whatever the OS prefers, as on vortex.dev. The docs render data-theme="dark" and press Dark for readers without scripts. Signed-off-by: Will Manning <will@willmanning.io>
a10y
approved these changes
Nov 4, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change gives the docs and the Explorer the same chrome as vortex.dev and bench, and serves both from one Vercel project.
/explorer/. explore.vortex.dev serves it at the root, and docs.vortex.dev/explorer redirects there.After merge, move the explore.vortex.dev domain to the docs' Vercel project. Until then, it serves its last deploy.
Not in this change: one favicon set, one share image, and the GitHub star count.
Screenshots
Before is production. After is a local build.
Docs
Dark, 1440px
Dark, 390px
Light, 1440px
Light, 390px
Docs footer
Dark, 1440px
Light, 1440px
Docs 404
Dark, 1440px
Dark, 390px
Light, 1440px
Light, 390px
Explorer start page
Dark, 1440px
Dark, 390px
Light, 1440px
Light, 390px
Explorer file view
Dark, 1440px
Dark, 390px
Light, 1440px
Light, 390px
Explorer 404
Dark, 1440px
Dark, 390px
Light, 1440px
Light, 390px
🤖 Generated with Claude Code