Repository navigation
Fix the mixed-dimension chunk test in vortex-bench - #11236
Merged
Merged
Conversation
The test expected the "Mismatched types" error text, which #10080 removed. The test now checks that the error names both vector dtypes, which differ only in their dimension. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
connortsui20
marked this pull request as ready for review
November 4, 2026 17:51
robert3005
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chunked_input_with_mixed_dimensions_returns_errorhas failed ondevelopsince #10080 removed the "Mismatched types" text that it looks for. CI excludesvortex-benchfrom nextest, so CI never ran it. The conversion still rejects chunks with different vector dimensions at thevortex_ensure_eq!inlist_to_vector_ext, so only the assertion was stale.Changes
The test now checks that the error names both vector dtypes: dimension 2 from the second chunk against dimension 3 from the first.