Skip to content

Commit 6f7091d

Browse files
authored
Fix semantic conflict in vortex-file tests (#10731)
## Summary Develop doesn't compile vortex-file's tests. #10533 added `nested_empty_list_roundtrip`, which calls `ListArray::try_new` with three arguments, but #10594 had already added a fourth, the execution context. Both passed CI on their own. Since #10533 merged, the Rust build, lint and test jobs fail on develop and on every PR. ## Changes - `nested_empty_list_roundtrip` creates an execution context and passes it to both `ListArray::try_new` calls, as `nested_list_of_list_roundtrip` just above it already does. ## Testing - `cargo nextest run -p vortex-file -E 'test(/nested_empty_list_roundtrip|nested_list_of_list_roundtrip/)'` (5 passed) - `cargo clippy -p vortex-file --all-targets --all-features -- -D warnings` - `cargo +nightly-2026-09-10 fmt -p vortex-file --check` Signed-off-by: Matt Katz <mhkatz97@gmail.com>
1 parent a169338 commit 6f7091d

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

‎vortex-file/src/tests.rs‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2047,13 +2047,16 @@ async fn nested_list_of_list_roundtrip() -> VortexResult<()> {
20472047
#[tokio::test]
20482048
#[cfg_attr(miri, ignore)]
20492049
async fn nested_empty_list_roundtrip(#[case] validity: Validity) -> VortexResult<()> {
2050+
let mut ctx = SESSION.create_execution_ctx();
20502051
let inner = ListArray::try_new(
20512052
PrimitiveArray::new::<i32>(buffer![], Validity::NonNullable).into_array(),
20522053
buffer![0u32].into_array(),
20532054
Validity::NonNullable,
2055+
&mut ctx,
20542056
)?
20552057
.into_array();
2056-
let outer = ListArray::try_new(inner, buffer![0u32, 0, 0].into_array(), validity)?.into_array();
2058+
let outer = ListArray::try_new(inner, buffer![0u32, 0, 0].into_array(), validity, &mut ctx)?
2059+
.into_array();
20572060
let array = StructArray::from_fields(&[("nested", outer)])?.into_array();
20582061

20592062
let result = write_read_roundtrip(array.clone()).await?;

0 commit comments

Comments
 (0)