Skip to content

Commit 67ca878

Browse files
committed
ci: pass --runner to SF1000 bench queries
The bench binaries refuse the default runner ID in CI. Label records with the EC2 instance runs-on provisioned, as vx-bench does. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FDifRZhxcVd5gvt3dsDhu5
1 parent b1ce3c2 commit 67ca878

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

‎scripts/bench-memory.py‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,8 @@ def cmd_run_queries(args: argparse.Namespace) -> int:
225225
"gh-json",
226226
"--hide-progress-bar",
227227
"--track-memory",
228+
"--runner",
229+
args.runner,
228230
*options,
229231
]
230232
if args.engine == "duckdb":
@@ -365,6 +367,12 @@ def main() -> int:
365367
run.add_argument("--opt", action="append", default=[], help="Benchmark option, e.g. scale-factor=1000.0")
366368
run.add_argument("--out-dir", type=Path, required=True)
367369
run.add_argument("--phase-file", type=Path, required=True)
370+
run.add_argument(
371+
"--runner",
372+
# Matches vx-bench: label records with the EC2 instance runs-on actually provisioned.
373+
default=f"ec2_{os.environ['RUNS_ON_INSTANCE_TYPE']}" if "RUNS_ON_INSTANCE_TYPE" in os.environ else "local",
374+
help="Benchmark runner ID; the bench binaries refuse the default in CI",
375+
)
368376
run.add_argument("--fail-on-error", action="store_true")
369377

370378
summarize = sub.add_parser("summarize", help="Render the monitor CSV and query records as Markdown")

0 commit comments

Comments
 (0)