Skip to content

Commit 220a02d

Browse files
starbopsclaude
andcommitted
fix: address PR review comments and CI failures
- Update Go version from 1.24.4 to 1.23.4 in go.mod and CI - Fix database credentials mismatch in integration tests (postgres -> testuser) - Update HighPriority factory method to return priority 10 instead of 9 - Update related test assertions to expect priority 10 - Ensure all unit tests pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent fc5e158 commit 220a02d

File tree

8 files changed

+14
-14
lines changed

8 files changed

+14
-14
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
branches: [ main, develop ]
88

99
env:
10-
GO_VERSION: '1.24.4'
10+
GO_VERSION: '1.23.4'
1111

1212
# CI Optimization Strategy:
1313
# - All jobs use consistent caching with Go version in cache key

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/voidrunnerhq/voidrunner
22

3-
go 1.24.4
3+
go 1.23.4
44

55
require (
66
github.com/gin-contrib/cors v1.7.6

internal/api/integration/contract_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ func (s *ContractTestSuite) SetupSuite() {
4646
Host: "localhost",
4747
Port: "5432",
4848
Database: "voidrunner_test",
49-
User: "postgres",
50-
Password: "password",
49+
User: "testuser",
50+
Password: "testpassword",
5151
SSLMode: "disable",
5252
},
5353
JWT: config.JWTConfig{

internal/api/integration_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ func (s *IntegrationTestSuite) SetupSuite() {
4646
Host: "localhost",
4747
Port: "5432",
4848
Database: "voidrunner_test",
49-
User: "postgres",
50-
Password: "password",
49+
User: "testuser",
50+
Password: "testpassword",
5151
SSLMode: "disable",
5252
},
5353
JWT: config.JWTConfig{

internal/database/integration_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ func setupTestDatabase(t *testing.T) (*Connection, *Repositories) {
4040
cfg := &config.DatabaseConfig{
4141
Host: getEnvOrDefault("TEST_DB_HOST", "localhost"),
4242
Port: getEnvOrDefault("TEST_DB_PORT", "5432"),
43-
User: getEnvOrDefault("TEST_DB_USER", "postgres"),
44-
Password: getEnvOrDefault("TEST_DB_PASSWORD", ""),
43+
User: getEnvOrDefault("TEST_DB_USER", "testuser"),
44+
Password: getEnvOrDefault("TEST_DB_PASSWORD", "testpassword"),
4545
Database: getEnvOrDefault("TEST_DB_NAME", "voidrunner_test"),
4646
SSLMode: getEnvOrDefault("TEST_DB_SSL_MODE", "disable"),
4747
}
@@ -415,8 +415,8 @@ func setupBenchmarkDatabase(b *testing.B) (*Connection, *Repositories) {
415415
cfg := &config.DatabaseConfig{
416416
Host: getEnvOrDefault("TEST_DB_HOST", "localhost"),
417417
Port: getEnvOrDefault("TEST_DB_PORT", "5432"),
418-
User: getEnvOrDefault("TEST_DB_USER", "postgres"),
419-
Password: getEnvOrDefault("TEST_DB_PASSWORD", ""),
418+
User: getEnvOrDefault("TEST_DB_USER", "testuser"),
419+
Password: getEnvOrDefault("TEST_DB_PASSWORD", "testpassword"),
420420
Database: getEnvOrDefault("TEST_DB_NAME", "voidrunner_test"),
421421
SSLMode: getEnvOrDefault("TEST_DB_SSL_MODE", "disable"),
422422
}

internal/testutil/error_scenarios_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ func TestFactoryBuilders_ChainedCalls(t *testing.T) {
282282
assert.Equal(t, "Test Description", *task.Description)
283283
assert.Equal(t, models.ScriptTypePython, task.ScriptType)
284284
assert.Equal(t, models.TaskStatusPending, task.Status)
285-
assert.Equal(t, 9, task.Priority) // HighPriority overrides previous priority
285+
assert.Equal(t, 10, task.Priority) // HighPriority overrides previous priority
286286
})
287287

288288
t.Run("execution factory method chaining", func(t *testing.T) {
@@ -401,7 +401,7 @@ func TestFactoryPriorityMethods(t *testing.T) {
401401

402402
// Test HighPriority
403403
highPriorityTask := factory.HighPriority().Build()
404-
assert.Equal(t, 9, highPriorityTask.Priority)
404+
assert.Equal(t, 10, highPriorityTask.Priority)
405405

406406
// Test LowPriority
407407
factory = NewTaskFactory(userID)

internal/testutil/example_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ func TestFactories(t *testing.T) {
171171
assert.Equal(t, "Test Task", task.Name)
172172
assert.Equal(t, models.ScriptTypePython, task.ScriptType)
173173
assert.Equal(t, models.TaskStatusCompleted, task.Status)
174-
assert.Equal(t, 9, task.Priority) // High priority
174+
assert.Equal(t, 10, task.Priority) // High priority
175175
assert.Equal(t, 60, task.TimeoutSeconds)
176176
assert.Equal(t, "test", task.Metadata["environment"])
177177

internal/testutil/factories.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ func (f *TaskFactory) WithPriority(priority int) *TaskFactory {
193193

194194
// HighPriority sets high priority (8-10)
195195
func (f *TaskFactory) HighPriority() *TaskFactory {
196-
return f.WithPriority(9)
196+
return f.WithPriority(10)
197197
}
198198

199199
// LowPriority sets low priority (1-3)

0 commit comments

Comments
 (0)