Skip to content

Commit ff74f78

Browse files
committed
lib,bin: only include archive{,_entry}.h where needed.
1 parent bed6719 commit ff74f78

30 files changed

+167
-94
lines changed

bin/xbps-checkvers/main.c

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,20 @@
2626
*
2727
*/
2828

29+
#include <sys/stat.h>
30+
31+
#include <assert.h>
32+
#include <ctype.h>
33+
#include <dirent.h>
34+
#include <errno.h>
2935
#include <getopt.h>
36+
#include <limits.h>
3037
#include <stdbool.h>
31-
#include <stdio.h>
3238
#include <stddef.h>
39+
#include <stdio.h>
3340
#include <stdlib.h>
3441
#include <string.h>
35-
#include <errno.h>
36-
#include <ctype.h>
37-
#include <dirent.h>
38-
#include <limits.h>
39-
#include <sys/stat.h>
40-
#include <assert.h>
42+
#include <unistd.h>
4143

4244
#include <xbps.h>
4345

bin/xbps-create/main.c

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -22,25 +22,30 @@
2222
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
2323
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
2424
*/
25-
#include <sys/types.h>
25+
26+
#include <sys/mman.h>
2627
#include <sys/param.h>
2728
#include <sys/stat.h>
28-
#include <sys/mman.h>
29-
#include <stdio.h>
29+
#include <sys/types.h>
30+
31+
#include <assert.h>
32+
#include <dirent.h>
33+
#include <errno.h>
34+
#include <fcntl.h>
35+
#include <ftw.h>
36+
#include <getopt.h>
37+
#include <libgen.h>
38+
#include <locale.h>
39+
#include <stdarg.h>
3040
#include <stdbool.h>
41+
#include <stdio.h>
3142
#include <stdlib.h>
3243
#include <string.h>
3344
#include <strings.h>
34-
#include <stdarg.h>
35-
#include <errno.h>
36-
#include <assert.h>
3745
#include <unistd.h>
38-
#include <getopt.h>
39-
#include <ftw.h>
40-
#include <fcntl.h>
41-
#include <libgen.h>
42-
#include <locale.h>
43-
#include <dirent.h>
46+
47+
#include <archive.h>
48+
#include <archive_entry.h>
4449

4550
#include <xbps.h>
4651
#include "queue.h"

bin/xbps-install/fetch_cb.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,20 @@
3131
*/
3232

3333
#include <sys/param.h>
34-
#include <sys/types.h>
3534
#include <sys/stat.h>
3635
#include <sys/time.h>
36+
#include <sys/types.h>
37+
38+
#include <errno.h>
39+
#include <fcntl.h>
3740
#include <stdio.h>
3841
#include <stdlib.h>
3942
#include <string.h>
40-
#include <errno.h>
41-
#include <fcntl.h>
43+
#include <time.h>
44+
#include <unistd.h>
4245

4346
#include <xbps.h>
47+
4448
#include "defs.h"
4549

4650
static int v_tty; /* stderr is a tty */

bin/xbps-install/util.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,17 @@
2323
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
2424
*/
2525

26-
#include <stdio.h>
27-
#include <stdbool.h>
28-
#include <stdlib.h>
26+
#include <sys/ioctl.h>
27+
28+
#include <assert.h>
2929
#include <errno.h>
3030
#include <fnmatch.h>
31+
#include <stdbool.h>
32+
#include <stdio.h>
33+
#include <stdlib.h>
3134
#include <string.h>
3235
#include <strings.h>
33-
#include <sys/ioctl.h>
34-
#include <assert.h>
36+
#include <unistd.h>
3537

3638
#include <xbps.h>
3739
#include "defs.h"

bin/xbps-query/show-info-files.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,16 @@
2323
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
2424
*/
2525

26-
#include <stdio.h>
26+
#include <assert.h>
27+
#include <errno.h>
28+
#include <fnmatch.h>
29+
#include <libgen.h>
30+
#include <limits.h>
2731
#include <stdbool.h>
32+
#include <stdio.h>
2833
#include <stdlib.h>
2934
#include <string.h>
30-
#include <errno.h>
31-
#include <limits.h>
32-
#include <libgen.h>
33-
#include <fnmatch.h>
34-
#include <assert.h>
35+
#include <unistd.h>
3536

3637
#include <xbps.h>
3738
#include "defs.h"

bin/xbps-rindex/index-add.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,17 @@
2424
*/
2525

2626
#include <sys/stat.h>
27-
#include <stdio.h>
27+
28+
#include <assert.h>
29+
#include <dirent.h>
30+
#include <errno.h>
31+
#include <fcntl.h>
32+
#include <libgen.h>
2833
#include <stdbool.h>
34+
#include <stdio.h>
2935
#include <stdlib.h>
3036
#include <string.h>
31-
#include <errno.h>
32-
#include <dirent.h>
33-
#include <libgen.h>
34-
#include <assert.h>
35-
#include <fcntl.h>
37+
#include <unistd.h>
3638

3739
#include <xbps.h>
3840
#include "defs.h"

bin/xbps-rindex/index-clean.c

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,21 @@
2424
*/
2525

2626
#include <sys/stat.h>
27-
#include <stdio.h>
28-
#include <stdbool.h>
29-
#include <stdlib.h>
30-
#include <string.h>
31-
#include <errno.h>
27+
28+
#include <assert.h>
3229
#include <dirent.h>
30+
#include <errno.h>
31+
#include <fcntl.h>
3332
#include <libgen.h>
34-
#include <assert.h>
3533
#include <pthread.h>
36-
#include <fcntl.h>
34+
#include <stdbool.h>
35+
#include <stdio.h>
36+
#include <stdlib.h>
37+
#include <string.h>
38+
#include <unistd.h>
3739

3840
#include <xbps.h>
41+
3942
#include "defs.h"
4043

4144
static xbps_dictionary_t dest;

bin/xbps-rindex/remove-obsoletes.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,16 @@
2424
*/
2525

2626
#include <sys/stat.h>
27-
#include <stdio.h>
27+
28+
#include <assert.h>
29+
#include <dirent.h>
30+
#include <errno.h>
31+
#include <libgen.h>
2832
#include <stdbool.h>
33+
#include <stdio.h>
2934
#include <stdlib.h>
3035
#include <string.h>
31-
#include <errno.h>
32-
#include <dirent.h>
33-
#include <libgen.h>
34-
#include <assert.h>
36+
#include <unistd.h>
3537

3638
#include <xbps.h>
3739
#include "defs.h"

bin/xbps-rindex/repoflush.c

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,22 @@
2424
*/
2525

2626
#include <sys/stat.h>
27-
#include <stdio.h>
27+
28+
#include <assert.h>
29+
#include <dirent.h>
30+
#include <errno.h>
31+
#include <fcntl.h>
32+
#include <libgen.h>
2833
#include <stdbool.h>
34+
#include <stdio.h>
2935
#include <stdlib.h>
3036
#include <string.h>
31-
#include <errno.h>
32-
#include <dirent.h>
33-
#include <libgen.h>
34-
#include <assert.h>
35-
#include <fcntl.h>
37+
38+
#include <archive.h>
39+
#include <archive_entry.h>
3640

3741
#include <xbps.h>
42+
3843
#include "defs.h"
3944

4045
bool

include/xbps.h.in

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@
4040
#include <xbps/xbps_number.h>
4141
#include <xbps/xbps_string.h>
4242

43-
#include <archive.h>
44-
#include <archive_entry.h>
45-
4643
#define XBPS_MAXPATH 512
4744
#define XBPS_NAME_SIZE 64
4845

0 commit comments

Comments
 (0)