bin/xbps-query: actually report regex errors

Author: Duncaen

bin/xbps-query/ownedby.c

@@ -188,8 +188,13 @@ ownedby(struct xbps_handle *xhp, const char *pat, bool repo, bool regex)
 
 	if (regex) {
 		ffd.rematch = true;
-		if (regcomp(&ffd.regex, ffd.pat, REG_EXTENDED|REG_NOSUB|REG_ICASE) != 0)
+		rv = regcomp(&ffd.regex, ffd.pat, REG_EXTENDED|REG_NOSUB|REG_ICASE);
+		if (rv != 0) {
+			char errbuf[256];
+			regerror(rv, &ffd.regex, errbuf, sizeof(errbuf));
+			fprintf(stderr, "Failed to compile pattern: %s\n", errbuf);
 			return EINVAL;
+		}
 	}
 	if (repo)
 		rv = xbps_rpool_foreach(xhp, repo_ownedby_cb, &ffd);

bin/xbps-query/search.c

@@ -229,9 +229,15 @@ search(struct xbps_handle *xhp, bool repo_mode, const char *pat, const char *pro
 
 	sd.regex = regex;
 	if (regex) {
-		if (regcomp(&sd.regexp, pat, REG_EXTENDED|REG_NOSUB|REG_ICASE) != 0)
-			return errno;
+		rv = regcomp(&sd.regexp, pat, REG_EXTENDED|REG_NOSUB|REG_ICASE);
+		if (rv != 0) {
+			char errbuf[256];
+			regerror(rv, &sd.regexp, errbuf, sizeof(errbuf));
+			fprintf(stderr, "Failed to compile pattern: %s\n", errbuf);
+			return EINVAL;
+		}
 	}
+
 	sd.repo_mode = repo_mode;
 	sd.pat = pat;
 	sd.prop = prop;