lib: remove xbps_{rpool,repo}_get_pkg_plist

Only xbps_rpool_get_pkg_plist was used in one place and was easily
replaced with doing it "manually" with less code.

Author: Duncaen

include/xbps.h.in

@@ -1553,29 +1553,6 @@ xbps_array_t xbps_rpool_get_pkg_revdeps(struct xbps_handle *xhp, const char *pkg
  */
 xbps_array_t xbps_rpool_get_pkg_fulldeptree(struct xbps_handle *xhp, const char *pkg);
 
-/**
- * Iterate over the the repository pool and search for a metadata plist
- * file in a binary package matching `pattern'. If a package is matched
- * the plist file \a plistf will be internalized into a proplib dictionary.
- *
- * When \a pattern is a pkgname, the newest package available in repositories
- * will be used. Otherwise the first repository matching \a pattern.
- *
- * @param[in] xhp Pointer to the xbps_handle struct.
- * @param[in] pattern Package name or package pattern to match, i.e `foo>=1.0'.
- * @param[in] plistf Plist file name to match, i.e XBPS_PKGPROPS or XBPS_PKGFILES.
- *
- * @return An internalized proplib dictionary of \a plistf, otherwise NULL
- * and errno is set appropiately.
- *
- * @note if NULL is returned and errno is ENOENT, that means that
- * binary package file has been found but the plist file could not
- * be found.
- */
-xbps_dictionary_t xbps_rpool_get_pkg_plist(struct xbps_handle *xhp,
-					   const char *pattern,
-					   const char *plistf);
-
 /**@}*/
 
 /** @addtogroup repo */
@@ -1724,20 +1701,6 @@ xbps_dictionary_t xbps_repo_get_pkg(struct xbps_repo *repo, const char *pkg);
  */
 xbps_dictionary_t xbps_repo_get_virtualpkg(struct xbps_repo *repo, const char *pkg);
 
-/**
- * Returns a pkg dictionary of the matching \a plist file from a binary package,
- * by looking at its package dictionary (\a pkgd) returned by a repository or rpool.
- *
- * @param[in] xhp Pointer to the xbps_handle struct.
- * @param[in] pkgd Package dictionary returned by xbps_{repo,rpool}_get_xxxpkg().
- * @param[in] plist Plist filename to internalize from matching binary package.
- *
- * @return The pkg dictionary on success, NULL otherwise.
- */
-xbps_dictionary_t xbps_repo_get_pkg_plist(struct xbps_handle *xhp,
-					xbps_dictionary_t pkgd,
-					const char *plist);
-
 /**
  * Returns a proplib array of strings with reverse dependencies from
  * repository \a repo matching the expression \a pkg.

lib/repo.c

@@ -473,22 +473,6 @@ xbps_repo_get_pkg(struct xbps_repo *repo, const char *pkg)
 	return pkgd;
 }
 
-xbps_dictionary_t
-xbps_repo_get_pkg_plist(struct xbps_handle *xhp, xbps_dictionary_t pkgd,
-		const char *plist)
-{
-	xbps_dictionary_t bpkgd;
-	char *url;
-
-	url = xbps_repository_pkg_path(xhp, pkgd);
-	if (url == NULL)
-		return NULL;
-
-	bpkgd = xbps_archive_fetch_plist(url, plist);
-	free(url);
-	return bpkgd;
-}
-
 static xbps_array_t
 revdeps_match(struct xbps_repo *repo, xbps_dictionary_t tpkgd, const char *str)
 {

lib/rpool.c

@@ -345,41 +345,3 @@ xbps_rpool_get_pkg_fulldeptree(struct xbps_handle *xhp, const char *pkg)
 {
 	return xbps_get_pkg_fulldeptree(xhp, pkg, true);
 }
-
-xbps_dictionary_t
-xbps_rpool_get_pkg_plist(struct xbps_handle *xhp,
-			 const char *pkg,
-			 const char *plistf)
-{
-	xbps_dictionary_t pkgd = NULL, plistd = NULL;
-	char *url;
-
-	assert(pkg != NULL);
-	assert(plistf != NULL);
-	/*
-	 * Iterate over the the repository pool and search for a plist file
-	 * in the binary package matching `pattern'. The plist file will be
-	 * internalized to a proplib dictionary.
-	 *
-	 * The first repository that has it wins and the loop is stopped.
-	 * This will work locally and remotely, thanks to libarchive and
-	 * libfetch!
-	 */
-	if (((pkgd = xbps_rpool_get_pkg(xhp, pkg)) == NULL) &&
-	    ((pkgd = xbps_rpool_get_virtualpkg(xhp, pkg)) == NULL))
-		goto out;
-
-	url = xbps_repository_pkg_path(xhp, pkgd);
-	if (url == NULL) {
-		errno = EINVAL;
-		goto out;
-	}
-	plistd = xbps_archive_fetch_plist(url, plistf);
-	free(url);
-
-out:
-	if (plistd == NULL)
-		errno = ENOENT;
-
-	return plistd;
-}