Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL-Encode links with special chars #721

Closed
jadyndev opened this issue Aug 24, 2023 · 2 comments
Closed

URL-Encode links with special chars #721

jadyndev opened this issue Aug 24, 2023 · 2 comments

Comments

@jadyndev
Copy link
Member

The links to the NORTx overview page on the camp23 site is broken in Firefox (116.0.3 apple-darwin):

The source shows: /c/camp2023/Nerds der OberRheinischen Tiefebene und der xHain (N\:O:R:T:x)
This is converted to: /c/camp2023/Nerds der OberRheinischen Tiefebene und der xHain (N/:O:R:T:x), which is invalid

This can be fixed by urlencoding the link in the source like this: /c/camp2023/Nerds%20der%20OberRheinischen%20Tiefebene%20und%20der%20xHain%20(N%5C%3AO%3AR%3AT%3Ax)

(encoding the \should be enough)

@saerdnaer
Copy link
Member

saerdnaer commented Sep 9, 2023

Just for the sake of completeness, where is a working link: https://media.ccc.de/c/camp2023/Nerds%20der%20OberRheinischen%20Tiefebene%20und%20der%20xHain%20(N%5C:O:R:T:x)
(We should have stripped down that tag to NORTx, and skip the long form – but now it's proably to late to change this…)

The corresponding line where we proably should fix this is here:

!= link_for(event.conference, tag)

@QbDesu
Copy link
Collaborator

QbDesu commented Jan 19, 2025

Since this is more than a year later, and links have been broken since then anyway, I just renamed the tag to NORTx. Nothing is lost, as any links to it were broken anyway. Even if you could theoretically link to it by manually fixing the link, I think breaking those links is a sacrifice we can make.

but now it's proably to late to change this

It's been broken for so long that now it's already late enough to change this again.

The tags should have been sanitized beforehand anyway. I don't think the code there needs to be updated unless another "saner" tag - for lack of better ways to express it - comes along and runs into this issue.

@QbDesu QbDesu closed this as completed Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants