Adds the possibility to sort the results in the search view #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @saerdnaer, I've seen that you merged my other PR. Is there any chance I could get some feedback on this one? Happy to fix things if necessary but I can understand if time is limited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does make:
query(q) andperson(p) queries andFeedback is very welcome! I'm a novice ruby/rails user and unsure if I did everything correctly. In case you need more changes, please let me know.
Also, is there a help for testing the app somewhere? I managed to use the Dockerfile with some slight adjustments (
# ENV BUNDLE_WITHOUT="development:test:doc") for testing withdocker compose run --remove-orphans voctoweb rails testbut this seems like not intended. Installing vagrant is also not what I want. So maybe building a dev and a prod image with different bundling seems like a good choice?