Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tags for voctoweb, part 1 #61

Closed
4 tasks done
saerdnaer opened this issue Jan 25, 2019 · 4 comments
Closed
4 tasks done

More tags for voctoweb, part 1 #61

saerdnaer opened this issue Jan 25, 2019 · 4 comments

Comments

@saerdnaer
Copy link
Member

saerdnaer commented Jan 25, 2019

As of now we only put conference acronym, local frab id and track into the voctoweb tags attribute list.
We should discuss how we get more tags for in individual talk into voctoweb, part 1:

  • add year as tag years as tags voctoweb#14
  • add new property for static conference tags named Publishing.Tags?
  • merge YouTube tags from tracker properties Publishing.Tags and Publishing.YouTube.Tags
  • use static conference tags from tracker property Publishing.Tags also for Voctoweb
    • maybe recycle some? code from
      def _select_tags(self, lang=None):
      """
      Build the tag list
      :param lang: if present the language will be added to the tags
      :return: Returns an array of tag strings
      """
      tags = []
      # if tags are set - copy them into the metadata dict
      if self.t.youtube_tags:
      tags.extend(map(str.strip, self.t.youtube_tags.split(',')))
      if self.t.track:
      tags.append(self.t.track)
      if self.t.day:
      tags.append('Day %s' % self.t.day)
      if self.t.room:
      tags.append(self.t.room)
      if lang:
      if lang in self.lang_map.keys():
      if self.t.languages[0] == lang:
      tags.append(self.t.acronym + self.lang_map[lang])
      tags.append(self.t.acronym + ' ov')
      else:
      tags.append(self.lang_map[lang] + ' (' + self.translation_strings[lang] + ')')
      tags.append(self.t.acronym + ' ' + lang)
      else:
      raise YouTubeException('language not in lang map')
      else:
      tags.append(self.t.acronym + ' ov')
      tags.append(self.t.acronym + ' ' + self.t.languages[0])
      tags.extend(self.t.people)
      tags.append(self.t.acronym)
      logging.debug('YouTube Tags: ' + str(tags))
      return tags

(extracted from #57)

@derpeter
Copy link
Contributor

Instead of using youtube tags we should have a global tag properties. If youtube needs extra tags we can concatenate that.
Adding the year is not problem.
There is not much code to recycle also the youtube code is not very nice.
Why are this checkboxes anyway if this is discussion?

@saerdnaer
Copy link
Member Author

The checkboxes can be ticked off, when the item is implemented.

@derpeter
Copy link
Contributor

I know what a checkbox is but they only make sense after a discussion not at the start of one.

voc-mng pushed a commit that referenced this issue Feb 13, 2019
use Publishing.Tags for vocotweb and youtube
add fahrplan.date as ticket.date to the ticket model
use date to add year to tags
#61
@derpeter
Copy link
Contributor

Thinks discussed here are now implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants