Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema: Missing definition /definitions/Answers #145

Closed
Kunsi opened this issue Dec 12, 2024 · 4 comments
Closed

JSON schema: Missing definition /definitions/Answers #145

Kunsi opened this issue Dec 12, 2024 · 4 comments

Comments

@Kunsi
Copy link

Kunsi commented Dec 12, 2024

https://github.com/voc/schedule/blob/master/validator/json/schema.json#L312 refers to https://c3voc.de/schedule/submission#/definitions/Answers which looks wrong, but the Answers definition is missing from the schema altogether, which leads to validation errors.

@saerdnaer saerdnaer self-assigned this Dec 12, 2024
@saerdnaer
Copy link
Member

Hmm, it should refer to https://github.com/voc/schedule/blob/master/validator/submission-json/schema.json#L267-L342 which is different to https://github.com/voc/schedule/blob/master/validator/submission-json/submission.json as I now realise... Its probably the best to move the answers defintion there...

@rixx
Copy link

rixx commented Dec 19, 2024

So exporters should now inline the full question rather than just including the question ID?

(FWIW: pretalx will at some point rename "question/answer" to "custom field", as that makes a lot more sense imo, and people regularly get confused by the current wording.)

@rixx
Copy link

rixx commented Dec 19, 2024

Notably, the schema.json does NOT include a type for speaker answers.

@saerdnaer
Copy link
Member

saerdnaer commented Dec 23, 2024

(FWIW: pretalx will at some point rename "question/answer" to "custom field", as that makes a lot more sense imo, and people regularly get confused by the current wording.)

Thats a good idea! So lets drop the answer field for now from the schema definition and let's revisit it as form a custom field, which could include a key additional to the question – I also saw some interesting ideas at custom field implementation in pretix...

HungNgien pushed a commit to HungNgien/eventyay-talk that referenced this issue Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants