You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The implementation in #3194 fetches all the column names and looks for them in the payload keys. The problem is that Oracle is case-insensitive by default and returns column names capitalized. We end up having to call lower() on the returned column names, which is not ideal.
These should technically be two different columns.
One possible solution is to make all column names case-sensitive, by putting them in quotes. We already do this to escape special characters and we can extend it to all column names. This should be covered by functional tests.
Acceptance criteria
Support the above scenario
Functional tests added for above scenario
The text was updated successfully, but these errors were encountered:
Follow-up from #3194
Overview
The implementation in #3194 fetches all the column names and looks for them in the payload keys. The problem is that Oracle is case-insensitive by default and returns column names capitalized. We end up having to call
lower()
on the returned column names, which is not ideal.For example, we could have a payload like
But the columns we'd get when querying would be
So we have to find a way to match between the two. Worse even, we could have something like this
These should technically be two different columns.
One possible solution is to make all column names case-sensitive, by putting them in quotes. We already do this to escape special characters and we can extend it to all column names. This should be covered by functional tests.
Acceptance criteria
The text was updated successfully, but these errors were encountered: