Skip to content

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Nov 27, 2025

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several improvements to the nightly multi-node testing infrastructure, focusing on logging and robustness. Key changes include adding a timeout to the ranktable generation, refactoring the server health-check logic in conftest.py to be more resilient and provide better diagnostics, and overhauling the run.sh script for better log management and failure analysis. These are valuable enhancements for test reliability. However, I've identified critical security vulnerabilities in the run.sh script related to unsafe directory removal commands, which could lead to unintended file deletions. These issues must be addressed.

Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
@Potabk Potabk marked this pull request as draft November 27, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant