Skip to content

Conversation

@liziyu179
Copy link
Contributor

@liziyu179 liziyu179 commented Nov 26, 2025

What this PR does / why we need it?

unregister mooncake layerwise connector

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 26, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to remove the MooncakeLayerwiseConnector feature. The changes correctly unregister the connector in vllm_ascend/distributed/__init__.py and remove the corresponding documentation and examples from docs/source/tutorials/multi_node_pd_disaggregation_mooncake.md. While the changes are correct, the PR is incomplete as it leaves behind dead code. To complete this refactoring, the implementation files for the removed feature should also be deleted. I've added specific comments pointing out the files that should be removed.

@liziyu179 liziyu179 force-pushed the remove_layerwise_connector branch from 45a59bc to 996d350 Compare November 26, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant