Skip to content

Commit cd58a64

Browse files
authored
[UT] Fix test_sample_recovered_tokens_pytorch_autoregressive (#3434)
### What this PR does / why we need it? This 'test_rejection_sampler' unit test is something wrong. > def test_sample_recovered_tokens_pytorch_autoregressive(self): > output_token_ids = torch.empty(2, dtype=torch.int32) > cu_num_draft_tokens = torch.tensor([1, 1]) > draft_token_ids = torch.tensor([0, 1]) len(draft_token_ids ) = 2, cu_num_draft_tokens should be torch.tensor([1, 2]) or torch.tensor([2, 2]) I fix it and set cu_num_draft_tokens = torch.tensor([1, 2]). The methods before and after optimization can pass. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? NA - vLLM version: v0.11.0rc3 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0 --------- Signed-off-by: lio <[email protected]>
1 parent 802c574 commit cd58a64

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

tests/ut/sample/test_rejection_sampler.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ def test_sample_recovered_tokens_pytorch_ngram(self):
174174
def test_sample_recovered_tokens_pytorch_autoregressive(self):
175175
"""Test recovered token sampling for autoregressive models"""
176176
output_token_ids = torch.empty(2, dtype=torch.int32)
177-
cu_num_draft_tokens = torch.tensor([1, 1])
177+
cu_num_draft_tokens = torch.tensor([1, 2])
178178
draft_token_ids = torch.tensor([0, 1])
179179
draft_probs = torch.tensor([
180180
[0.6, 0.1, 0.3],
@@ -201,3 +201,4 @@ def test_sample_recovered_tokens_pytorch_autoregressive(self):
201201
IS_NGRAM=False,
202202
)
203203
assert output_token_ids[0].item() == 0
204+
assert output_token_ids[1].item() == 0

0 commit comments

Comments
 (0)