Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing icons #7

Open
tsteinruecken opened this issue Apr 24, 2021 · 1 comment
Open

Missing icons #7

tsteinruecken opened this issue Apr 24, 2021 · 1 comment

Comments

@tsteinruecken
Copy link
Contributor

While merging the current status of this repo in the admin i've discovered that a few icons went missing or are now needed for ViUR3. I'm currently missing icons for:

  • switching view from icon to table view and vice versa
  • the csv-export action
  • opening the (large) text-editor
  • distinction between "Save & Close" and "Save & Continue" (or "Save & Add new Entry")

Furthermore, we have now more states for a bone in an edit-view (each state should have it's own icon):

  • Not set/unknown (eg used when opening an add formular before a bone has been touched by the user)
  • Invalidates other (this bone itself is okay, but due to it's value another bone has become invalid)
  • Empty (This bone is empty, but it's also not required, so it's still possible to submit the formular)
  • Invalid (The formular cannot be saved as this bone contains an invalid value (or the bone is empty and required))
  • Okay (The content of this bone have been validated)
@phneutral
Copy link
Member

With the new icon set we don't intend to create an icon for every other occasion, instead reuse fitting icons as much as possible. Studies have shown that buttons without a text label perform poorly, thus we do recommend to see the icon as an additional indicator.

  • icon / table view switch: we have to add these, they are already in use in several customer projects
  • action csv-export: download-file or download seem fitting for the purpose
  • open text editor: just plain old edit?
  • save actions: we have several icons in this regard save, save-all, save-file — the Vi uses save-file for both buttons, but highlights the preferred option as btn--primary

We already have feedback from several customers that too many labels in the edit-view are confusing. We should aim to reduce the number of labels not adding more and more.

  • Invalid: error or cancel
  • Okay: save

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants