Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving documentation about creating Sharded Keyspace. #1817

Closed
wants to merge 1 commit into from

Conversation

Satarupa22-SD
Copy link
Contributor

Adding this section would simplify the process for the users.
Resolves #1434

Signed-off-by: Satarupa Deb <[email protected]>
@Satarupa22-SD
Copy link
Contributor Author

@mattlord please look into this. Thanks.

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 5776374
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/66be5ab1a6838e000855d100
😎 Deploy Preview https://deploy-preview-1817--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be done in 21.0 docs at a minimum, as that is what will become 22.0 ...

Comment on lines +8 to +20

1. Create the keyspace
2. Define and apply the VSchema
3. Create physical shards
4. Create tablets (instances) for each shard
5. Initialize the schema on each shard
6. (Optional) Migrate data from an unsharded keyspace

Each of these steps is crucial for a fully functional sharded keyspace. This guide will walk you through these steps, with a focus on VSchema definition and usage.

{{< info >}}
**Note**: Applying the VSchema (step 2) only defines the logical structure of your sharded keyspace. It does not create physical shards, tablets, or initialize the schema. Attempting to query the database after only applying the VSchema will result in errors such as "no healthy tablet available". Ensure you complete all the steps listed above before attempting to use your sharded keyspace.
{{< /info >}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this helps resolve the issue. It attempts to explain Vitess concepts when that is done elsewhere (it's assumed that you have some basic concepts in mind before you ever get to this point). It is also a bit confusing to me as I'm not sure what a physical shard is, how that is that not made up of tablets and mysqld pairs, etc.

I believe that the issue would be resolved by noting here that it's assumed you have run the local examples steps 101 - 307 and linking to the source code for those or other relevant docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing it out. I will check the existing documentation and create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation about creating Sharded Keyspace should be clearer
2 participants