Do barrel exports / export * work in typescript?

[stephenh]

I'm moving a CRA app onto vitejs and running into issues with apollo-client, specifically I have a dependency in my node_modules that does:

import { ApolloLink, FetchResult, GraphQLRequest, Operation } from "@apollo/client";

Where @apollo/client is a barrel export file:

export * from './core';
export * from './react';

https://github.com/apollographql/apollo-client/blob/main/src/index.ts

But I end up getting Uncaught ReferenceError: ApolloLink is not defined.

If I manually change export * to export { ApolloLink } from './core' then the error goes away, but I get another for the next missing import. Like it seems like I'd have to "fix" / manually-expand all of the export *s in any dependencies I have.

I know that esbuild has limitation on isolatedModules behavior, but afaiu export * isn't/shouldn't (?) be one of them?

It seems like not supporting export * would break a ton of libraries... should this "just work" and I need to dig for some other root cause?

[stephenh]

Here's the start of one of the chunk files that has the error:

import {
  ApolloError,
  NetworkStatus,
  disableExperimentalFragmentVariables,
  disableFragmentWarnings,
  enableExperimentalFragmentVariables,
  equal,
  getApolloContext,
  import_graphql_tag,
  import_react,
  import_utilities as import_utilities2,
  import_utilities2 as import_utilities,
  invariant,
  mergeOptions,
  resetCaches
} from "/node_modules/.vite/chunk-SQI23CBE.js?v=252ef978";
import {
  require_tslib_es6
} from "/node_modules/.vite/chunk-G2OHUD2Q.js?v=252ef978";
import {
  __export
} from "/node_modules/.vite/chunk-45Q6ZGDB.js?v=252ef978";
import {
  __toModule
} from "/node_modules/.vite/chunk-CW3E54WM.js?v=252ef978";
import {
  __markAsModule
} from "/node_modules/.vite/chunk-7RL6IACX.js?v=252ef978";
import {
  require_react
} from "/node_modules/.vite/chunk-EGQFLM6K.js?v=252ef978";
import {
  __commonJS
} from "/node_modules/.vite/chunk-KHGO2BKN.js?v=252ef978";

// node_modules/@apollo/client/index.js
var require_client = __commonJS((exports) => {
  __markAsModule(exports);
  __export(exports, {
    ApolloCache: () => ApolloCache,
    ApolloClient: () => ApolloClient,
    ApolloConsumer: () => ApolloConsumer,
    ApolloError: () => ApolloError,
    ApolloLink: () => ApolloLink,
    ApolloProvider: () => ApolloProvider,
    Cache: () => Cache,
    DocumentType: () => DocumentType,
    HttpLink: () => HttpLink,
    InMemoryCache: () => InMemoryCache,
    MissingFieldError: () => MissingFieldError,
    NetworkStatus: () => NetworkStatus,
    Observable: () => import_utilities.Observable,
    ObservableQuery: () => ObservableQuery,
    checkFetcher: () => checkFetcher,
    concat: () => concat,
    createHttpLink: () => createHttpLink,
    createSignalIfSupported: () => createSignalIfSupported,
    defaultDataIdFromObject: () => defaultDataIdFromObject,
    disableExperimentalFragmentVariables: () => disableExperimentalFragmentVariables,
    disableFragmentWarnings: () => disableFragmentWarnings,
    empty: () => empty,
    enableExperimentalFragmentVariables: () => enableExperimentalFragmentVariables,
    execute: () => execute,
    fallbackHttpConfig: () => fallbackHttpConfig,
    from: () => from,
    fromError: () => fromError,
    fromPromise: () => fromPromise,
    getApolloContext: () => getApolloContext,
    gql: () => import_graphql_tag.default,
    isApolloError: () => isApolloError,
    isReference: () => import_utilities.isReference,
    makeReference: () => import_utilities.makeReference,
    makeVar: () => makeVar,
    mergeOptions: () => mergeOptions,
    operationName: () => operationName,
    parseAndCheckHttpResponse: () => parseAndCheckHttpResponse,
    parser: () => parser,
    resetApolloContext: () => getApolloContext,
    resetCaches: () => resetCaches,
    rewriteURIForGET: () => rewriteURIForGET,
    selectHttpOptionsAndBody: () => selectHttpOptionsAndBody,
    selectURI: () => selectURI,
    serializeFetchParameter: () => serializeFetchParameter,
    setLogVerbosity: () => setVerbosity,
    split: () => split,
    throwServerError: () => throwServerError,
    toPromise: () => toPromise,
    useApolloClient: () => useApolloClient,
    useLazyQuery: () => useLazyQuery,
    useMutation: () => useMutation,
    useQuery: () => useQuery,
    useReactiveVar: () => useReactiveVar,
    useSubscription: () => useSubscription
  });
});

// node_modules/@apollo/client/link/utils/toPromise.js
function toPromise(observable) {
  var completed = false;
  return new Promise(function(resolve, reject) {
    observable.subscribe({
      next: function(data) {
        if (completed) {
          invariant.warn("Promise Wrapper does not support multiple results from Observable");
        } else {
          completed = true;
          resolve(data);
        }
      },
      error: reject
    });
  });
}

// node_modules/@apollo/client/link/utils/fromPromise.js
function fromPromise(promise) {
  return new import_utilities2.Observable(function(observer) {
    promise.then(function(value) {
      observer.next(value);
      observer.complete();
    }).catch(observer.error.bind(observer));
  });
}

// node_modules/@apollo/client/react/context/ApolloConsumer.js
var ApolloConsumer = function(props) {
  var ApolloContext = getApolloContext();
  return import_react.default.createElement(ApolloContext.Consumer, null, function(context) {
    false ? invariant(context && context.client, 27) : invariant(context && context.client, 'Could not find "client" in the context of ApolloConsumer. Wrap the root component in an <ApolloProvider>.');
    return props.children(context.client);
  });
};

// node_modules/@apollo/client/react/hooks/useApo

And it's specifically this line:

    ApolloLink: () => ApolloLink,

That is failing.

So it looks like maybe something of the other Apollo...s exports are working?

[stephenh]

Weird, I upgraded apollo to the latest 3.3.x released and it very slightly changed where the error was, now it's this line:

    gql: () => lib_default,

Uncaught ReferenceError: lib_default is not defined
    gql chunk-FTIHZG5N.js:68
    get chunk-CW3E54WM.js:14
    <anonymous> graphql-types.tsx:5
chunk-FTIHZG5N.js:68:16
    gql chunk-FTIHZG5N.js:68
    get chunk-CW3E54WM.js:14
    <anonymous> graphql-types.tsx:5
    InnerModuleEvaluation self-hosted:2379

From the same file, but ~10-20 lines down from the error on the prior version of apollo-client...

[stephenh]

Hm, lib_default is from a import gql from graphql-tag, searching for graphq-tag in the output I see it multiple times:

  vite:resolve 2ms   graphql-tag -> null +0ms
...later...
  vite:resolve 9ms   graphql-tag -> /home/stephen/homebound/internal-frontend/node_modules/@apollo/client/node_modules/graphql-tag/lib/index.js +0ms

Would the fact that it shows up once as -> null be the source of this error?

[stephenh]

Looks like I'm running into something that has happened to others:

https://github.com/apollographql/apollo-client/blob/main/src/core/index.ts#L94

But I'm on the latest apollo-client (that fix was from ~a year ago) and latest vitejs.

I tried forcing a bump from esbuild 0.9 to 0.11.12 just to see what happens, but get another import error, so dunno, seems like I'm stuck for now.

[stephenh]

It seems like something specific to porting my legacy app, b/c I can't reproduce it in a new instance. Will close this out.