fix(i3s): fix for /statistics/summary path #3154
Conversation
| @@ -37,6 +37,10 @@ const PATH_DESCRIPTIONS: {test: RegExp; extensions: string[]}[] = [ | |||
| test: /statistics\/f_\d+\/\d+$/, | |||
| extensions: ['.json.gz'] | |||
| }, | |||
| { | |||
| test: /statistics\/summary$/, | |||
There was a problem hiding this comment.
This path is not a part of the spec https://docs.ogc.org/cs/17-014r9/17-014r9.html#_example_1_2_slpk_structure_summary_for_3d_objects
There was a problem hiding this comment.
Oh, I didn't know that but I see it now. I create this pull request based on fix from @dariaterekhova-actionengine. I described the issue in #3148 (reply in thread).
There was a problem hiding this comment.
I don't understand that slpk archive from Esri/i3s-spec is not compatible with the standard.
Am I missing something?
There was a problem hiding this comment.
If this is simply a clean extension of the standard (i.e. an additional optional path that provides additional, non-critical information), then there is no compatibility issues.
It would however be nice to separate these things in the code (using some lightweight mechanism separate files, functions, tables etc) and call it out in comments.
It would also be nice to cover it in the documentation as well:
- Add a section that lists Esri additions to the standard
- Mention which ones are supported, and how (if this path is present, how do we use it and what extra capabilities are offered to the user as a result).
| @@ -37,6 +37,10 @@ const PATH_DESCRIPTIONS: {test: RegExp; extensions: string[]}[] = [ | |||
| test: /statistics\/f_\d+\/\d+$/, | |||
| extensions: ['.json.gz'] | |||
| }, | |||
| { | |||
| test: /statistics\/summary$/, | |||
There was a problem hiding this comment.
If this is simply a clean extension of the standard (i.e. an additional optional path that provides additional, non-critical information), then there is no compatibility issues.
It would however be nice to separate these things in the code (using some lightweight mechanism separate files, functions, tables etc) and call it out in comments.
It would also be nice to cover it in the documentation as well:
- Add a section that lists Esri additions to the standard
- Mention which ones are supported, and how (if this path is present, how do we use it and what extra capabilities are offered to the user as a result).
No description provided.